Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop linea swaps crashing when approval is required #11859

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

jclancy93
Copy link
Contributor

@jclancy93 jclancy93 commented Oct 18, 2024

Description

Due to some unknown issue with transaction timing and lifecycle, swaps on Linea that require an approval causes the mobile app to crash. This bug also exists on extension and was patched here. This PR ports over this same logic to mobile while to immediately fix the issue and will be approved once a more robust fix is in place

Related issues

Fixes: #11804

Manual testing steps

  1. Swap into new ERC20 token on Linea
  2. Swap new ERC20 token to another token on Linea
  3. Mobile app should not crash

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 18, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@davibroc davibroc added the QA Passed A successful QA run through has been done label Oct 18, 2024
davibroc
davibroc previously approved these changes Oct 18, 2024
Copy link
Contributor

@davibroc davibroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the fix and it worked now

@jclancy93
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@jclancy93 jclancy93 added team-swaps needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Oct 18, 2024
@jclancy93 jclancy93 marked this pull request as ready for review October 18, 2024 11:49
@jclancy93 jclancy93 requested review from a team as code owners October 18, 2024 11:49
Copy link

@jclancy93 jclancy93 added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit d55ddfe Oct 18, 2024
39 checks passed
@jclancy93 jclancy93 deleted the MMS-1596-linea-swaps-crash branch October 18, 2024 15:53
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.35.0 Issue or pull request that will be included in release 7.35.0 team-swaps
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: App will crash when swapping unapproved token on Linea
4 participants