Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Implements push notifications FCM support #11865

Conversation

Jonathansoufer
Copy link
Contributor

@Jonathansoufer Jonathansoufer commented Oct 18, 2024

Description

This PR implements support to FCM (Firebase Cloud Messaging) on both iOS and Android on mobile.

Related issues

Fixes: NOTIFY-1219

Manual testing steps

  1. Go to Settings --> Notifications --> Enable
  2. Open a separated device (or extension) repeat the process above
  3. Do any transaction between the two clients/devices
  4. Leave the transaction recipient open to see it in Foreground
  5. Put app in background to see a native notification

Screenshots/Recordings

Before

After

PushNotifications.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Mobile Platform team team-notifications DEPRECATED: Use "team-assets" instead labels Oct 18, 2024
@Jonathansoufer Jonathansoufer self-assigned this Oct 18, 2024
@Jonathansoufer Jonathansoufer requested review from a team as code owners October 18, 2024 11:51
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Jonathansoufer Jonathansoufer removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 23, 2024
@Jonathansoufer Jonathansoufer added Run Smoke E2E Triggers smoke e2e on Bitrise and removed skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. labels Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5bbb60b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f85b0638-a955-4f7c-ace3-2a7b572d10b1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
59.9% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@Jonathansoufer Jonathansoufer added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Oct 24, 2024
auto-merge was automatically disabled November 7, 2024 18:17

Pull request was closed

@Jonathansoufer Jonathansoufer deleted the NOTIFY-1219/push-notifications-not-triggered-remotelly branch November 7, 2024 18:17
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-mobile-platform Mobile Platform team team-notifications DEPRECATED: Use "team-assets" instead
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant