Chain permissions - Next Steps explainer/PoC #11868
Draft
+121
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
adonesky1
changed the title
adonesky1
changed the title
| ); | ||
|
|
||
| const toggleRevokeAllNetworkPermissionsModal = useCallback(() => { | ||
| // not sure if we want to do this here or on the sub modal | ||
| // which provides the extra warning that it will fully disconnect you |
adonesky1
force-pushed
the
ad/permitted-chains-permission-merged-next-steps
branch
from
bba4443 to
8f2c5cf
Compare
|
| const [selectedNetworkIds, setSelectedNetworkIds] = useState<string[]>([]); | ||
| const [selectedChainIds, setSelectedChainIds] = useState<string[]>([]); | ||
| const networkConfigurations = useSelector(selectNetworkConfigurations); | ||
|
|
There was a problem hiding this comment.
@adonesky1 Engine.context.PermissionController.getCaveat came from this POC PR originally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PoC for hooking up the permissions management modal
Screen.Recording.2024-10-18.at.10.19.50.AM.mov
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist