feat: v7.34.1 #12221
Merged
feat: v7.34.1 #12221
+46
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Action (#11879) - chore: New Crowdin translations by Github Action (#11356) Co-authored-by: metamaskbot <[email protected]> Co-authored-by: sethkfman <[email protected]> [4f13426](4f13426) Co-authored-by: MetaMask Bot <[email protected]> Co-authored-by: metamaskbot <[email protected]> Co-authored-by: sethkfman <[email protected]>
- chore: revert custom tags sentry (#11861) ## **Description** Revert this [PR](#11623) <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [e168bcc](e168bcc) Co-authored-by: tommasini <[email protected]>
## **Description** Cherry pick bf5bb97 ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: tommasini <[email protected]>
This PR cherry-picks #11769 --------- Co-authored-by: Xiaoming Wang <[email protected]> Co-authored-by: Nico MASSART <[email protected]> Co-authored-by: Xiaoming Wang <[email protected]> Co-authored-by: Nicholas Ellul <[email protected]> Co-authored-by: legobt <[email protected]>
…11947) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [In the recent changes](https://github.com/MetaMask/core/pull/4364/files) token exchange rates are determined from `marketData` which has no `value` property anymore. Hence `fetchTokenContractExchangeRates` was failing because rather than `value` it should now read `price` Please note that this is already fixed in `main` in the `assets-controllers@33`. ## **Related issues** Fixes: #11901 ## **Manual testing steps** 1. Simulations should show fiat values properly ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After**  ## **Pre-merge author checklist** - [X] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
This PR cherry-picks #11995 --------- Co-authored-by: Salim TOUBAL <[email protected]>
- refactor(ramp): update ramp copy (#10952) ## **Description** This PR contains the changes requested to comply with some regulations ## **Related issues** Fixes: ## **Manual testing steps** 1. Navigate through the changed screens and see the new copy ## **Screenshots/Recordings** | Image | |:-----:| | <img width="400" src="https://github.com/user-attachments/assets/21a1c07e-95d2-43cd-ae35-fc6e6b42c9de" /> | | <img width="400" src="https://github.com/user-attachments/assets/e94c1380-f01a-4769-a5d4-fb9be20c0c9c" /> | | <img width="400" src="https://github.com/user-attachments/assets/ad49c1a3-5772-45cf-8ae0-2417d3534f36" /> | | <img width="400" src="https://github.com/user-attachments/assets/e85edab5-cd74-476d-a993-7b39a4ea3fcb" /> | | <img width="400" src="https://github.com/user-attachments/assets/96150ff3-d0fe-464c-9ed6-72f6afa8bcdd" /> | | <img width="400" src="https://github.com/user-attachments/assets/1849b585-d7a9-46c8-b553-a87e2db0f7a0" /> | ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [6facd6d](6facd6d) Co-authored-by: Pedro Pablo Aste Kompen <[email protected]>
…way to new one (#12032) - fix: migrate from decommissioned ipfs gateway to new one (#11985) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** - adds state migration for users with decommissioned IPFS gateway - adds migration tests - adds new target gateway (dweb.link) to list and make it replace decommissioned gateway. >[!NOTE] > this is only a state migration, the user will not have any visible warnings. It will only show the new gateway as selected instead of the decommissioned one if it was in their state. ## **Related issues** Fixes #11692 ## **Manual testing steps** ```gherkin Feature: Migrate from decommissioned gateway to dweb.link Scenario: Verify non migrated gateway Given an installed app that was built before the decommission of https://cloudflare-ipfs.com/ipfs/ (pre ac79785, for latest is 7.32.0) When go to security & privacy settings And select https://cloudflare-ipfs.com/ipfs/ Then see "Your current IPFS gateway is down" as decommissioned gateway does not respond Scenario: Check migration Given the current PR app installed When go to security & privacy settings Then see "https://dweb.link/ipfs/" gateway selected ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** Simulator Screenshot - iPhone 16 Pro - 2024-10-23 at 22 00 21 <img src="https://github.com/user-attachments/assets/f1e9ddc5-d40c-4726-9ad9-222dcaedf8aa" width="300px"/> ### **After** Simulator Screenshot - iPhone 16 Pro - 2024-10-23 at 22 15 31 <img src="https://github.com/user-attachments/assets/090cfbed-1e20-4cf1-8f4f-8fa2f1f1bcd8" width="300px"/> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: legobeat <[email protected]> Co-authored-by: tommasini <[email protected]> [9b8599e](9b8599e) Co-authored-by: Nico MASSART <[email protected]> Co-authored-by: legobeat <[email protected]> Co-authored-by: tommasini <[email protected]>
## **Description** Cherry pick: #11935 ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
bump build number to 1468 for v7.34.0 - RC-3
This PR cherry-picks #11977 --------- Co-authored-by: tommasini <[email protected]> Co-authored-by: tommasini <[email protected]>
…tton (#12058) - refactor: replace swap slider with swap button (#12030) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Feedback was received suggesting that the "swipe to swap" UI was often navigating back instead of executing the swap. This PR replaces the swipe with a button to address this issue and simplify the interaction. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to the swap page 2. Get quotes 3. See swap button ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <img width="310" alt="Screenshot 2024-10-25 at 17 22 47" src="https://github.com/user-attachments/assets/f93ba955-164e-4a6b-895b-400a56c8bda0"> <!-- [screenshots/recordings] --> ### **After** <img width="309" alt="Screenshot 2024-10-25 at 17 24 04" src="https://github.com/user-attachments/assets/3aacf0c1-1066-4dbd-ac62-bef8682c2660"> <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [a2de45b](a2de45b) Co-authored-by: Bryan Fullam <[email protected]>
This PR cherry-picks #12036 --------- Co-authored-by: Salim TOUBAL <[email protected]>
This PR cherry-picks #12064 --------- Co-authored-by: Salim TOUBAL <[email protected]>
This PR cherry-picks #12048 --------- Co-authored-by: Mpendulo Ndlovu <[email protected]> Co-authored-by: salimtb <[email protected]>
- feat: add favorites to browser menu (#12060) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> We're adding in a "Go to Favorites" option into the browser menu so users can navigate to https://home.metamask.io, allowing them to access their previous favorites pages. After switching to the Portfolio dapps for a user's homepage, we received a decent amount of user feedback wanting this feature back in. ## **Related issues** Fixes: ## **Manual testing steps** 1. Open the in-app browser 2. Navigate to any website that's not https://home.metamask.io 3. Open the browser menu by tapping on the "more" icon 4. See the new "Go to Favorites" option, tap that. 5. Confirm that the user is taken to https://home.metamask.io ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before**  ### **After**  Actual https://github.com/user-attachments/assets/e6aabfd6-3746-4075-ad47-b8140afbc3fd <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Signed-off-by: Kai Huang <[email protected]> Co-authored-by: Cal-L <[email protected]> Co-authored-by: legobeat <[email protected]> Co-authored-by: Cal Leung <[email protected]> [36d2535](36d2535) Signed-off-by: Kai Huang <[email protected]> Co-authored-by: Kaihuang72490 <[email protected]> Co-authored-by: Cal-L <[email protected]> Co-authored-by: legobeat <[email protected]> Co-authored-by: Cal Leung <[email protected]>
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** The network names for Ethereum mainnet and Linea mainnet should be standardized as "Ethereum Mainnet" and "Linea" to align with our third-party provider. core PR: [adjust network names](MetaMask/core#4865) <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: #11895 ## **Manual testing steps** 1. Move from v7.33 ( or any previous release version ) to this branch 2. Check the name of Ethereum mainnet and Linea ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
- fix: validate chain before send (#12048) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR validates the chain id before handling the deeplink for making an ethereum send. ## **Related issues** Fixes: [11966](#11966) ## **Manual testing steps** 1. Open the deeplink https://metamask.app.link/send/0x2990079bcdEe240329a520d2444386FC119da21a@56?value=3e18 2. Ensure that BNB is not added as a chain on the wallet 3. You should see an error "Unable to find network with chain id" ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> https://github.com/user-attachments/assets/c790fcdc-7737-4718-b5b5-f117151ea0a2 ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [d1a58ab](d1a58ab) Co-authored-by: Mpendulo Ndlovu <[email protected]>
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR introduces two new workflows in Bitrise - `build_android_release_and_upload_sourcemaps` - Runs `build_android_release` and uploads sourcemaps to Sentry - `build_ios_release_and_upload_sourcemaps` - Runs `build_ios_release` and uploads sourcemaps to Sentry By default, both `build_android_release` and `build_ios_release` will not automatically upload sourcemaps to Sentry Related PR - #11490 ## **Related issues** Fixes: #10812 ## **Manual testing steps** To build release AND upload sourcemaps, use the two workflows in Bitrise: - `build_android_release_and_upload_sourcemaps` - `build_ios_release_and_upload_sourcemaps` To only build release without uploading sourcemaps, use the two workflows in Bitrise: - `build_android_release` - `build_ios_release` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> In this test, we ran the default `build_ios_release` and `build_android_release`, which resulted in no sourcemaps being uploaded - Android - https://app.bitrise.io/build/bc568645-d1e4-418c-bea0-6aafe8f2e21c - iOS - https://app.bitrise.io/build/e7c224b3-c0f3-4be9-afa0-b3ad423d0da7 In this test, we enabled Sentry sourcemap upload and re-used `build_ios_release` and `build_android_release` to mimic the workflows that uploads sourcemaps. We can see in the two builds that it successfully uploads sourcemaps. - Android - https://app.bitrise.io/build/d93989e0-3ca8-4bab-aaf2-48b0ca104986 - iOS - https://app.bitrise.io/build/b24edfed-b020-4ac1-bf44-191d284b099b Sourcemaps uploaded - Android: <img width="870" alt="Screenshot 2024-10-23 at 6 08 21 PM" src="https://github.com/user-attachments/assets/44b24050-7337-4cc8-b13a-5aa9795bb72d"> - iOS: <img width="851" alt="Screenshot 2024-10-23 at 6 08 31 PM" src="https://github.com/user-attachments/assets/c26e8b8c-a767-46ee-ade6-5c519767893c"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…12095) - fix: fix render detected tokens section (#11923) ## **Description** Fix render detected tokens section ## **Related issues** Fixes: #11890 ## **Manual testing steps** 1. Import an account with tokens 2. Click on import detected tokens 3. Once all tokens are imported you should not see the section telling you "0 tokens found in this account" ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/ccc86b0f-fdbd-4012-8df8-5f6d19072cea ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [a9fc0dd](a9fc0dd) Co-authored-by: sahar-fehri <[email protected]>
- fix: Contacts disappearing (#12089) ## **Description** Fix for address book controller state (contacts) be populated when initialise if data is persisted. Build APK for test upgrade: https://app.bitrise.io/build/56fd9c34-7024-4478-abf9-4d27a8dd035c?tab=log ## **Related issues** Fixes: ## **Manual testing steps** 1. Installed[ 7.32.0](https://app.bitrise.io/build/58561a11-2021-4b91-8c41-9f185fc038cf?tab=artifacts) 2. imported wallet 3. added contact 4. updated to 7.34.0 apk with fix: https://app.bitrise.io/build/56fd9c34-7024-4478-abf9-4d27a8dd035c?tab=log 5. the contact is still there ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://github.com/user-attachments/assets/b102ba5d-7123-405b-b02e-8955f70ee598 <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [7c4fa63](7c4fa63) Co-authored-by: tommasini <[email protected]> Co-authored-by: Nico MASSART <[email protected]>
…ncoming transactions settings (#12096) - fix(11895): remove duplicate networks in incoming transactions settings (#12016) ## **Description** We now list `mainnet` networks in the `rpcEndpoints` so the previous logic rendering `mainnet` in separate functions are no longer need. Here is the relevant [PR](https://github.com/MetaMask/metamask-mobile/pull/11705/files) that has those changes. The `rpcEndpoints` do not render in the right order so filtering by Linea Mainnet and Ethereum Mainnet is needed. ## **Related issues** Related Issue: [#11895](#11895) ## **Manual testing steps** 1. Go to this settings page 2. Click on "Security & Privacy" 3. Scroll down and toggle "Show incoming transactions" and confirm that it works 4. Confirm that the duplicate `mainnet` networks are gone ## **Screenshots/Recordings**  | Before | After |:---:|:---:| ||| ### **Before** NA ### **After** NA ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [60bdb96](60bdb96) Co-authored-by: Vince Howard <[email protected]> Co-authored-by: Nico MASSART <[email protected]>
## **Description** Patches tokenDetection updates to swap tokenList with tokensChainsCache ## **Related issues** Fixes: Related: MetaMask/core#4821 ## **Manual testing steps** 1. I added a console.log in detectTokens fct in tokenDetectionController to check how many times its being called 2. Switch between two networks back and forth and detectTokens should be triggered just once 3. If you switch to a new network for the first time you will see an extra call but it should happen only the first time and not everytime ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/406ac8c3-d7a0-4b37-b4c0-398d0ff60bef ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/2c737fb5-926a-4c6a-8a98-d240022145ef ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
This PR cherry picks 23d311c --------- Co-authored-by: Nico MASSART <[email protected]>
… selectedAccount (#12122) - fix: Reapply migration 52 to fix undefined selectedAccount (#12115) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR fixes #11866 where it ensures that selectedAccount in the AccountsController is defined. ## **Related issues** Fixes: #11866 ## **Manual testing steps** 1. Run `main` and create a wallet with 3 accounts, select account 1 2. Kill the app and apply a migration that sets `selectedAccount` in the AccountsController to undefined, re-run yarn watch and re-open app 3. Notice that the app is stuck on the splash screen 4. Kill the app and run this branch, which applies the migration that fixes the issue. Notice that the app is now accessible again ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> <img width="900" alt="Screenshot 2024-10-30 at 4 42 44 PM" src="https://github.com/user-attachments/assets/394f1b4c-741c-4c7f-993e-b0120e16588e"> <img width="961" alt="Screenshot 2024-10-30 at 4 43 07 PM" src="https://github.com/user-attachments/assets/37c685b2-925a-45c5-a7c4-7fadec8cba6f"> ### **After** <!-- [screenshots/recordings] --> App is accessible again <img width="444" alt="Screenshot 2024-10-30 at 10 11 24 PM" src="https://github.com/user-attachments/assets/cc0cb9ef-2a5b-4804-a9e8-eac93cc4212d"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [dfcd8c8](dfcd8c8) Co-authored-by: Cal Leung <[email protected]>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
## **Description** Cherry-picks #12205 ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** fix: Update transaction-controller version (#12228) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: OGPoyraz <[email protected]>
… on this branch <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
sethkfman
added
team-mobile-platform
Run Smoke E2E
|
|
|
@metamaskbot update-attributions |
|
Attributions update failed. You can review the logs or retry the attributions update here |
metamaskbot
added
the
release-7.37.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hot fix to address:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist