Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set default selectedNetworkClientId to 'mainnet' if no matching with entry on network list #12227

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Nov 7, 2024

Description

This PR implements a fix for Migration 60 to handle cases where selectedNetworkClientId does not match any entry within networkConfigurationsByChainId. If no corresponding networkClientId is found, the migration will now set selectedNetworkClientId to 'mainnet' by default.

Related issues

Fixes: #11657

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…entry exists in networkConfigurationsByChainId
Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb changed the title fix: set default selectedNetworkClientId to 'mainnet' if no matching … fix: set default selectedNetworkClientId to 'mainnet' if no matching with entry on network list Nov 7, 2024
@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 7, 2024
Copy link

sonarcloud bot commented Nov 7, 2024

Copy link
Contributor

github-actions bot commented Nov 7, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 217b7c7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1ac32bd6-f3c1-425a-a38c-a0cfbbe6e5cc

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb marked this pull request as ready for review November 7, 2024 09:53
@salimtb salimtb requested a review from a team as a code owner November 7, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sentry] Error: Engine does not exist
2 participants