Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: privacy mode is enabled in account selector by params #12235

Merged
merged 12 commits into from
Nov 11, 2024
Merged

fix: privacy mode is enabled in account selector by params #12235

merged 12 commits into from
Nov 11, 2024
+846 −12

Conversation

vinnyhoward
Copy link
Contributor

Description

Current Issue: The AccountSelectorList subscribed to the privacyMode selector at a component level. It had the unintended consequence of hiding the balance when choosing an account during the send flow.

Solution: Passing it as a param to allow fine tuned control over hidden balances in the AccountSelector component

Related issues

Follow Fix: #3240

Manual testing steps

  1. Click on the privacy mode button on the home screen
  2. Click on the account selector to verify your balance is hidden
  3. Click on the send flow and attempt to switch accounts - confirm that your balance isn't hidden here while pivacy mode is enabled

Screenshots/Recordings

Before After
before after

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward requested review from a team as code owners November 7, 2024 20:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward added team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 4e8b9fb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/77a56c04-7a41-4104-a4fb-96d711aebbf7

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 24b6416
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/38eb0f67-06b6-4725-aa04-922efb1ecaab

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: adc745c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a1e74b83-b958-4fcf-8e13-faded23fd9d5

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9baa15e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2348d7d7-1465-4d0d-80f6-9fce8f2a9e9a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 02f1a9d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/73667efc-134b-4ea9-873b-0265aa556fb2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1edc8b4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1a79fb20-f101-474c-b979-e332ede6ef64

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

sethkfman
sethkfman previously approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jonybur
jonybur previously approved these changes Nov 8, 2024
View reviewed changes
@vinnyhoward vinnyhoward added this pull request to the merge queue Nov 8, 2024
@vinnyhoward vinnyhoward removed this pull request from the merge queue due to a manual request Nov 8, 2024
@vinnyhoward vinnyhoward added this pull request to the merge queue Nov 8, 2024
@vinnyhoward vinnyhoward removed this pull request from the merge queue due to a manual request Nov 8, 2024
@vinnyhoward vinnyhoward dismissed stale reviews from jonybur and sethkfman via aee4253 November 8, 2024 22:42
@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: aee4253
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bf51aa4a-8b32-40b3-8730-2cdaa14cc6c1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7c6dae3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8e667fdf-eef2-427d-8809-6274d0320ed9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sethkfman
sethkfman approved these changes Nov 9, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

EtherWizard33
EtherWizard33 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 11, 2024
@vinnyhoward vinnyhoward added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 61ab41a Nov 11, 2024
49 checks passed
@vinnyhoward vinnyhoward deleted the fix-3420-privacy-mode-toggle branch November 11, 2024 15:45
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
@gauthierpetetin gauthierpetetin added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EtherWizard33 EtherWizard33 EtherWizard33 approved these changes

@sethkfman sethkfman sethkfman approved these changes

@jonybur jonybur jonybur left review comments

Assignees
No one assigned
Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-wallet-ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vinnyhoward @sethkfman @jonybur @EtherWizard33 @gauthierpetetin @metamaskbot