Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add tags to UI Startup sentry transaction #12286

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Nov 14, 2024

Description

Needs testing in QA build to verify tags

Android QA build: https://app.bitrise.io/build/7d1397e9-b56a-488b-8b23-509d53b2989a?tab=log

Link showing the tags: https://metamask.sentry.io/performance/trace/67e58676fea44614bac9ad8af72324cd/?dataset=transactions&field=title&field=project&field=user.display&field=timestamp&name=All%20Errors&node=txn-0ae4a10418b8431e88633814e51d032f&project=2651591&query=device%3AMAR-LX1B&queryDataset=transaction-like&sort=-timestamp&source=discover&statsPeriod=90d&timestamp=1731585973&yAxis=count%28%29

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise team-tiger Tiger team (for tech debt reduction + performance improvements) labels Nov 14, 2024
@tommasini tommasini requested a review from a team as a code owner November 14, 2024 11:39
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Nov 14, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 439284e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f94700e8-e9b9-4a7e-b832-0ce21f87eac3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini marked this pull request as draft November 14, 2024 11:51
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 56.39%. Comparing base (940258e) to head (a042551).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
app/util/sentry/utils.js 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12286      +/-   ##
==========================================
+ Coverage   56.38%   56.39%   +0.01%     
==========================================
  Files        1791     1795       +4     
  Lines       40494    40583      +89     
  Branches     5087     5099      +12     
==========================================
+ Hits        22833    22888      +55     
- Misses      16109    16136      +27     
- Partials     1552     1559       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tommasini tommasini marked this pull request as ready for review November 14, 2024 12:08
@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 14, 2024
Copy link
Contributor

github-actions bot commented Nov 14, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 877325e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9a185521-dfb2-476a-98a3-de8b9e210249

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@MarioAslau MarioAslau added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 14, 2024
Copy link
Contributor

github-actions bot commented Nov 14, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9014901
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f5872e28-1101-4286-a4e8-27ed495d1678

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini enabled auto-merge November 14, 2024 16:41
Copy link

sonarcloud bot commented Nov 14, 2024

@tommasini tommasini added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit 4fa0c15 Nov 14, 2024
42 of 43 checks passed
@tommasini tommasini deleted the chore/add-tags-UI-Startup branch November 14, 2024 17:04
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-tiger Tiger team (for tech debt reduction + performance improvements)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants