Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: breaking selector due to missing controller state #12375

Merged
merged 8 commits into from
Nov 25, 2024
Merged

fix: breaking selector due to missing controller state #12375

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
df8e3b9
fix: breaking selector
Prithpal-Sooriya Nov 21, 2024
4540de3
Merge branch 'main' into hotfix/fix-breaking-selector
Prithpal-Sooriya Nov 21, 2024
01a1859
fix: ensure notification hooks are not called when flag is disabled
Prithpal-Sooriya Nov 22, 2024
825d2a4
Merge branch 'hotfix/fix-breaking-selector' of github.com:MetaMask/me…
Prithpal-Sooriya Nov 22, 2024
344002f
fix: tests and linting
Prithpal-Sooriya Nov 22, 2024
3f63b51
Merge branch 'main' into hotfix/fix-breaking-selector
Prithpal-Sooriya Nov 22, 2024
585196e
Merge branch 'main' into hotfix/fix-breaking-selector
Prithpal-Sooriya Nov 25, 2024
743a5e9
Merge branch 'main' into hotfix/fix-breaking-selector
Prithpal-Sooriya Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions app/selectors/notifications/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,21 @@ type AuthenticationState =
type UserStorageState = UserStorageController.UserStorageControllerState;

const selectAuthenticationControllerState = (state: RootState) =>
state?.engine?.backgroundState?.AuthenticationController;
state?.engine?.backgroundState?.AuthenticationController ??
AuthenticationController.defaultState;

const selectUserStorageControllerState = (state: RootState) =>
state?.engine?.backgroundState?.UserStorageController;
state?.engine?.backgroundState?.UserStorageController ??
UserStorageController.defaultState;
Prithpal-Sooriya marked this conversation as resolved.
Show resolved Hide resolved

const selectNotificationServicesControllerState = (state: RootState) =>
state?.engine?.backgroundState?.NotificationServicesController;
state?.engine?.backgroundState?.NotificationServicesController ??
NotificationServicesController.defaultState;

export const selectIsProfileSyncingEnabled = createSelector(
selectUserStorageControllerState,
(userStorageControllerState: UserStorageState) =>
userStorageControllerState.isProfileSyncingEnabled,
userStorageControllerState?.isProfileSyncingEnabled,
Prithpal-Sooriya marked this conversation as resolved.
Show resolved Hide resolved
);
export const selectIsProfileSyncingUpdateLoading = createSelector(
selectUserStorageControllerState,
Expand Down
Loading