Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Stellar wallet #948

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

New Stellar wallet #948

wants to merge 4 commits into from

Conversation

khanti42
Copy link
Collaborator

@khanti42 khanti42 commented Nov 25, 2024

Closes #985

@khanti42
Copy link
Collaborator Author

khanti42 commented Jan 6, 2025

@Montoya, the builder mentioned some screenshots you wanted to update. Would you like to include them here now, or should we plan for a follow-up update? The builder also wants to update the URL to the production version later, so we could align the screenshot updates with that change if it works for you. Wdyt ?

@khanti42 khanti42 marked this pull request as ready for review January 6, 2025 15:13
@khanti42 khanti42 requested review from Montoya and a team as code owners January 6, 2025 15:13
@Montoya
Copy link
Contributor

Montoya commented Jan 7, 2025

I don't recall anything about updating screenshots @khanti42

Copy link
Contributor

@Montoya Montoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Snap codebase is full of console.log statements that include user / state metadata. All of these console log messages need to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Snap] Stellar
2 participants