Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unblock wallet_switchEthereumChain #2634

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Unblock wallet_switchEthereumChain #2634

wants to merge 10 commits into from

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Aug 13, 2024 •
edited
Loading

This removes wallet_switchEthereumChain from the BLOCKED_RPC_METHODS list.

Closes MetaMask/MetaMask-planning#2938.
Closes #2654.

Blocked by:

@codecov Codecov
Copy link

codecov bot commented Aug 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.28%. Comparing base (4c532f7) to head (f2aa83e).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2634   +/-   ##
=======================================
  Coverage   94.27%   94.28%           
=======================================
  Files         478      479    +1     
  Lines        9999    10014   +15     
  Branches     1499     1500    +1     
=======================================
+ Hits         9427     9442   +15     
  Misses        572      572

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mrtenz Mrtenz marked this pull request as ready for review August 13, 2024 07:27
@Mrtenz Mrtenz requested a review from a team as a code owner August 13, 2024 07:27
@Mrtenz Mrtenz mentioned this pull request Aug 13, 2024
Closed
7 tasks
@Mrtenz Mrtenz force-pushed the mrtenz/unblock-wallet_switchEthereumChain branch from 2a66d50 to fd11f16 Compare August 21, 2024 11:01
@Mrtenz
Copy link
Member Author

Mrtenz commented Aug 21, 2024

@metamaskbot update-pr

@socket-security Socket Security
Copy link

socket-security bot commented Aug 21, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] environment Transitive: filesystem, network +29 6.27 MB metamaskbot
npm/@metamask/[email protected] Transitive: environment, filesystem, network +3 262 kB metamaskbot
npm/[email protected] None 0 639 kB pimterry

🚮 Removed packages: npm/[email protected]

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented Aug 21, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@Mrtenz
Copy link
Member Author

Mrtenz commented Aug 21, 2024

@SocketSecurity ignore npm/@metamask/[email protected]

This is ours.

@Mrtenz Mrtenz marked this pull request as draft August 21, 2024 11:36
Mrtenz
Mrtenz commented Aug 21, 2024
View reviewed changes
...ges/snaps-jest/src/internals/simulation/middleware/internal-methods/switch-ethereum-chain.ts
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we could consider full support for wallet_switchEthereumChain, and actually updating the provider configuration etc., but for now this simply makes the wallet_switchEthereumChain method always return null.

@Mrtenz Mrtenz mentioned this pull request Oct 8, 2024
Merged
Mrtenz added a commit that referenced this pull request Oct 8, 2024
@Mrtenz
Add isSnapId utility function (#2808)
a80db22 
This adds a `isSnapId` function which accepts any value, and returns a
boolean if the input is a valid Snap ID or not.

This is extracted from #2634.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add wallet_switchEthereumChain support to snaps-jest
2 participants
@Mrtenz @metamaskbot