Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Flow example snap #2732

Merged
merged 13 commits into from
Sep 19, 2024
Merged

Send Flow example snap #2732

merged 13 commits into from
Sep 19, 2024

Conversation

GuillaumeRx
Copy link
Contributor

This PR adds an example snap that demonstrate a send flow built with custom UI.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.35%. Comparing base (64de07b) to head (ed072fb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2732   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files         476      476           
  Lines       10137    10137           
  Branches     1542     1542           
=======================================
  Hits         9565     9565           
  Misses        572      572           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Just left some minor comments.

packages/examples/packages/send-flow/LICENSE.APACHE2 Outdated Show resolved Hide resolved
packages/examples/packages/send-flow/LICENSE.MIT0 Outdated Show resolved Hide resolved
packages/examples/packages/send-flow/README.md Outdated Show resolved Hide resolved
packages/examples/packages/send-flow/README.md Outdated Show resolved Hide resolved
packages/examples/packages/send-flow/package.json Outdated Show resolved Hide resolved
@GuillaumeRx GuillaumeRx requested a review from Mrtenz September 19, 2024 13:08
@GuillaumeRx GuillaumeRx force-pushed the gr/send-flow-example branch 2 times, most recently from f2393aa to 7ce23fa Compare September 19, 2024 14:40
@GuillaumeRx GuillaumeRx marked this pull request as ready for review September 19, 2024 14:51
@GuillaumeRx GuillaumeRx requested a review from a team as a code owner September 19, 2024 14:51
@GuillaumeRx GuillaumeRx merged commit 2ad6cd1 into main Sep 19, 2024
165 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/send-flow-example branch September 19, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants