Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore query strings when parsing URLs #2883

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

FrederikBolding
Copy link
Member

Mobile uses a polyfill for fetch that adds certain query strings to fetch URLs, this breaks our CLI server implementation as it doesn't expect query strings. This PR changes the server implementation to ignore query strings and only look at pathname.

@FrederikBolding FrederikBolding requested a review from a team as a code owner November 13, 2024 10:49
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.49%. Comparing base (8efc3b3) to head (17489d1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2883   +/-   ##
=======================================
  Coverage   94.48%   94.49%           
=======================================
  Files         486      486           
  Lines       10398    10401    +3     
  Branches     1591     1594    +3     
=======================================
+ Hits         9825     9828    +3     
  Misses        573      573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding merged commit 8815d9b into main Nov 13, 2024
166 checks passed
@FrederikBolding FrederikBolding deleted the fb/ignore-query-string-in-server branch November 13, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants