-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement MultichainRouter
and onProtocolRequest
(SIP-26)
#2875
Draft
FrederikBolding
wants to merge
23
commits into
main
Choose a base branch
from
fb/sip26
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
FrederikBolding
force-pushed
the
fb/sip26
branch
from
November 20, 2024 10:49
5321c38
to
cc4715d
Compare
FrederikBolding
changed the title
wip: Add MultichainRoutingController
feat: Implement MultichainRoutingController (SIP-26)
Nov 20, 2024
FrederikBolding
changed the title
feat: Implement MultichainRoutingController (SIP-26)
feat: Implement Nov 20, 2024
MultichainRoutingController
and onProtocolRequest
(SIP-26)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2875 +/- ##
==========================================
+ Coverage 94.49% 94.56% +0.06%
==========================================
Files 487 489 +2
Lines 10451 10558 +107
Branches 1604 1620 +16
==========================================
+ Hits 9876 9984 +108
+ Misses 575 574 -1 ☔ View full report in Codecov by Sentry. |
FrederikBolding
force-pushed
the
fb/sip26
branch
from
November 21, 2024 10:45
9817cfc
to
8b6e698
Compare
FrederikBolding
changed the title
feat: Implement
feat: Implement Nov 21, 2024
MultichainRoutingController
and onProtocolRequest
(SIP-26)MultichainRouter
and onProtocolRequest
(SIP-26)
FrederikBolding
force-pushed
the
fb/sip26
branch
2 times, most recently
from
December 5, 2024 09:48
047e488
to
ba2412d
Compare
FrederikBolding
force-pushed
the
fb/sip26
branch
from
December 13, 2024 12:55
ba2412d
to
5d70af9
Compare
FrederikBolding
force-pushed
the
fb/sip26
branch
from
December 16, 2024 12:30
0c62acf
to
5e42ee7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
MultichainRouter
that can handle routing of non-EVM requests received via the multichain API. The multichain API should integrate this by callingMultichainRouter.handleRequest
for any requests that are not understood by our existing JSON-RPC stack.Additionally this PR implements
onProtocolRequest
, a new handler that Snaps can choose to register if they want to service protocol (non signing) requests for a given set of methods for one or more chains. The endowment is registered as follows:This implementation follows https://metamask.github.io/SIPs/SIPS/sip-26
Closes #2898