Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement MultichainRouter and onProtocolRequest (SIP-26) #2875

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Nov 5, 2024

This PR adds a MultichainRouter that can handle routing of non-EVM requests received via the multichain API. The multichain API should integrate this by calling MultichainRouter.handleRequest for any requests that are not understood by our existing JSON-RPC stack.

Additionally this PR implements onProtocolRequest, a new handler that Snaps can choose to register if they want to service protocol (non signing) requests for a given set of methods for one or more chains. The endowment is registered as follows:

"initialPermissions": {
  "endowment:protocol": {
    "scopes": {
      "<caip2_chainId>": {
        "methods": [
          // List of supported methods
        ],
        "notifications": [
          // List of supported notifications
        ]
      }
    }
  }
}

This implementation follows https://metamask.github.io/SIPs/SIPS/sip-26

Closes #2898

@FrederikBolding FrederikBolding changed the title wip: Add MultichainRoutingController feat: Implement MultichainRoutingController (SIP-26) Nov 20, 2024
@FrederikBolding FrederikBolding changed the title feat: Implement MultichainRoutingController (SIP-26) feat: Implement MultichainRoutingController and onProtocolRequest (SIP-26) Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.56%. Comparing base (b0036f5) to head (0c62acf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2875      +/-   ##
==========================================
+ Coverage   94.49%   94.56%   +0.06%     
==========================================
  Files         487      489       +2     
  Lines       10451    10558     +107     
  Branches     1604     1620      +16     
==========================================
+ Hits         9876     9984     +108     
+ Misses        575      574       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding changed the title feat: Implement MultichainRoutingController and onProtocolRequest (SIP-26) feat: Implement MultichainRouter and onProtocolRequest (SIP-26) Nov 21, 2024
@FrederikBolding FrederikBolding force-pushed the fb/sip26 branch 2 times, most recently from 047e488 to ba2412d Compare December 5, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement routing logic and endowment for SIP-26
1 participant