Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow background prop on Container #2906

Open
GuillaumeRx opened this issue Nov 25, 2024 · 4 comments · May be fixed by MetaMask/metamask-extension#29095
Open

Allow background prop on Container #2906

GuillaumeRx opened this issue Nov 25, 2024 · 4 comments · May be fixed by MetaMask/metamask-extension#29095
Assignees
@david0xd

Comments

@GuillaumeRx
Copy link
Contributor

GuillaumeRx commented Nov 25, 2024 •
edited by FrederikBolding
Loading

We should make the background configurable for Container to allow Snaps to choose between white and gray background. There may be places where we want to not honor this background choice, e.g. insights.
@ajeetd
Copy link

ajeetd commented Nov 25, 2024 •
edited
Loading

Support for this should be for: Pre-installed Snaps && hideSnapsBranding

Do a review of how components look on white background.

@ajeetd
Copy link

ajeetd commented Dec 2, 2024

Confirmations background for Bitcoin/Solana?

@FrederikBolding FrederikBolding changed the title Let hideSnapBranding make the dialog background white Allow background prop on Container Dec 2, 2024
@ajeetd
Copy link

ajeetd commented Dec 5, 2024

Implement and fix PoC as needed.

@david0xd david0xd self-assigned this Dec 9, 2024
This was referenced Dec 11, 2024
Open
Draft
@ajeetd
Copy link

ajeetd commented Dec 11, 2024

Erik following up with DS on additional color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david0xd david0xd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(snaps): Add background color prop to Snaps UI Container component MetaMask/metamask-extension
4 participants
@david0xd @GuillaumeRx @ajeetd @eriknson