Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odd spec passes validation #169

Open
GoogleCodeExporter opened this issue Mar 24, 2015 · 1 comment
Open

odd spec passes validation #169

GoogleCodeExporter opened this issue Mar 24, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

This spec passes validation, but I don't think it should ... I haven't 
determined what happens when you try to load one of these, but I imagine that 
it might not be pretty:

    <version: '1.0-baseline'>

    spec for: #'common' do: [
        spec blessing: #'baseline'.
        spec repository: 'dictionary://Metacello_Dev_Cycle_Repository'.
        spec package: 'AAA' with: [
                spec requires: #('MetacelloTestConfigurationOfFoo' ). ].
        spec group: 'MetacelloTestConfigurationOfFoo' with: #('MetacelloTestConfigurationOfFoo' ). ].

discovered while writing tests for Issue 5. Here's the test case:

    | expectException issues validationError |
    expectException := false.
    [ 
    MetacelloToolBox
        createBaseline: '1.0-baseline'
        for: self configurationName asString
        repository: 'dictionary://' , self repositoryName asString
        requiredProjects: #()
        packages: #('AAA')
        dependencies: {('AAA' -> #('MetacelloTestConfigurationOfFoo'))}
        groups: {('MetacelloTestConfigurationOfFoo' -> #('MetacelloTestConfigurationOfFoo'))} ]
        on: MetacelloValidationFailure
        do: [ :ex | 
            issues := ex issues.
            expectException := true ].
    self assert: expectException.
    self assert: issues size == 1.
    validationError := issues at: 1.
    self assert: validationError reasonCode == #versionCompositionError.
    self assert: validationError callSite == #validateProject:version:

Original issue reported on code.google.com by [email protected] on 18 Jan 2012 at 10:59

@GoogleCodeExporter
Copy link
Author

will look into with https://github.com/dalehenrich/metacello-work/issues/5 ...

Original comment by [email protected] on 19 May 2012 at 9:49

  • Added labels: Milestone-1.0
  • Removed labels: Milestone-1.0-beta.32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant