Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute non-const visitor by const visitor where ever possible #1102

Open
muellch opened this issue Feb 6, 2021 · 0 comments
Open

Substitute non-const visitor by const visitor where ever possible #1102

muellch opened this issue Feb 6, 2021 · 0 comments
Labels

Comments

@muellch
Copy link
Contributor

muellch commented Feb 6, 2021

After #617 was resolved by #1094, only the ASTStringifier now uses the const visitor interface.

For every other visitor implemented, one should check if it is possible to switch to the const visitor interface.

This task cannot be started before #648 is completed, since a const variant of the expr::getData method is required to make most visitors const, which cannot be provided as long as data is lazily initialized in the getter.

@muellch muellch changed the title Substitute non-const visitor by const visitor whereever possible Substitute non-const visitor by const visitor where ever possible Feb 6, 2021
@muellch muellch added backend dawn related refactoring labels Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant