Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DDP._CurrentPublicationInvocation to get userId #223

Open
zimme opened this issue May 31, 2017 · 3 comments
Open

Use DDP._CurrentPublicationInvocation to get userId #223

zimme opened this issue May 31, 2017 · 3 comments
Assignees

Comments

@zimme
Copy link
Member

zimme commented May 31, 2017

Let's use DDP._CurrentPublicationInvocation to get the userId if it's available, otherwise fall back to the current method to be backwards-compatible.

Possible since meteor/meteor#8629.

@zimme zimme self-assigned this May 31, 2017
@gregory
Copy link

gregory commented Nov 20, 2017

it's crazy how much time code is spent in the try/catch - would be much more efficient to rely on DDP._CurrentMethodInvocation.get() || DDP._CurrentPublicationInvocation.get();

@zimme
Copy link
Member Author

zimme commented Nov 20, 2017

@gregory I would happily accept a PR for this =)

@gregory
Copy link

gregory commented Nov 22, 2017

Thanks @zimme - Not a blocker, will try to find some time for this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants