Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do tests run slower than with practicalmeteor:mocha? #23

Open
thebarty opened this issue Mar 28, 2017 · 3 comments
Open

Why do tests run slower than with practicalmeteor:mocha? #23

thebarty opened this issue Mar 28, 2017 · 3 comments

Comments

@thebarty
Copy link

Hi guys,

I found that my test-suite runs much slower using this package (SERVER-side ONLY tests) than running them with practicalmeteor:mocha. It is NOT only this package - I have also tried practicalmeteor:mocha-xunit-reporter which is unusable as it hits the 120minute limit on CircleCi.

Here are some results:
dispatch:mocha OSX => 291 passing (26m)
dispatch:mocha CircleCi => NOT yet tested
practicalmeteor:mocha OSX => 263 passing (17m) // WINNER
practicalmeteor:mocha-xunit-reporter OSX => NOT yet tested
practicalmeteor:mocha-xunit-reporter CircleCi => hits the 120minutes limit (=UNUSABLE)

I am just wondering... maybe someone else is experiencing this too. And maybe someone finds a performance hack

@0o-de-lally
Copy link
Contributor

@thebarty I'm also perplexed at this. Some of my integration tests failed on timeout when I first started using dispatch. I don't see anything in the dipatcha:mocha code that is blocking. Practicalmeteor:mocha's code is far more complex.

@thebarty
Copy link
Author

@keyscores Strange stuff, but I can definetly confirm that for my tests this is the correct data. I just had my first successful pass using dispatch:mocha on CircleCi. So the new data looks like this:

dispatch:mocha OSX => 291 passing (26m)
dispatch:mocha CircleCi => 291 passing (24m) // Wohaa! Faster than on OSX. Faster than practicalmeteor:mocha-xunit-reporter
practicalmeteor:mocha OSX => 263 passing (17m)
practicalmeteor:mocha-xunit-reporter OSX => NOT yet tested
practicalmeteor:mocha-xunit-reporter CircleCi => hits the 120minutes limit (=UNUSABLE)

Are you experiencing similar results?

This is the setup I am using (last topic) https://forums.meteor.com/t/enhanced-but-simply-stupid-circleci-setup-that-first-runs-unit-integration-tests-and-then-chimp-acceptance-tests/35086/7

@aldeed
Copy link
Contributor

aldeed commented Mar 28, 2017

@thebarty Interesting. I don't really have any ideas. Both packages rely on the same core mocha package and operate pretty much the same way for running server tests. We can accept a PR if anyone can figure out some solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants