-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with fourseven:[email protected]
and Internal Meteor Packages
#324
Comments
Thank you for submitting this issue! We, the Members of Meteor Community Packages take every issue seriously. However, we contribute to these packages mostly in our free time. If you think this issue is trivial to solve, don't hesitate to submit Please also consider sponsoring the maintainers of the package. |
This is indeed a very possible issue. For some reason, I didn't consider that the package might be used without api.addFiles('x.scss', 'client', { isImport: true }); Thanks for the detailed information! This makes it easy to investigate and fix the problem. |
* master: Internal Meteor Packages: improve root file detection logic for imports and package files Meteor-Community-Packages#324
fully tested!
I have forked the test environment you created and extended it with additional variations to cover more possible use cases. Now, everything works flawlessly in all scenarios. You can check it here: |
Describe the Bug
I'm using
fourseven:scss
with internal Meteor packages, and since version5.0.0-alpha.1
, I've encountered the following problem:To Reproduce
I’ve created a project to reproduce this behavior, available here: https://github.com/LionelGuerin/meteor_forkedseven_scss
In the folder sass_tests/sass, I'm using
fourseven:[email protected]
.To reproduce the error, run the following commands:
Expected behavior
In the folder sass_tests/sass_forked, there is another Meteor app that uses a slightly modified version of fourseven:[email protected].
This custom package is located in:
sass_tests/sass_forked/packages/forkedseven_scss
The only change made is on line 183, where filePath is replaced in the compileAsync function:
I’m pretty sure this isn’t the correct way to do it, but I don’t know how to fix it properly (and that's why I haven’t made a PR).
Thank you in advance for your time and help ! :)
The text was updated successfully, but these errors were encountered: