Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP wireframe mode crashes if LivingEntity has armor with enchantment glint #5019

Open
RacoonDog opened this issue Nov 20, 2024 · 2 comments
Labels
crash Oopsie

Comments

@RacoonDog
Copy link
Contributor

RacoonDog commented Nov 20, 2024

Description

Enchantment glint renderer uses a VertexConsumers.Dual created from two calls to VertexConsumerProvider#getBuffer with differing RenderLayer arguments. Since our wireframe renderer returns the same VertexConsumer for both, and VertexConsumers.Dual forces them to be different, it throws an exception.

Link to crash report/log

https://mclo.gs/BPPvfVU

Meteor Version

0.5.9-2204

Minecraft Version

1.21.3

@RacoonDog RacoonDog added the crash Oopsie label Nov 20, 2024
@RacoonDog
Copy link
Contributor Author

There are probably other locations where VertexConsumers.Dual would cause a similar crash that haven't been found yet

@RacoonDog
Copy link
Contributor Author

RacoonDog commented Nov 20, 2024

There are probably other locations where VertexConsumers.Dual would cause a similar crash that haven't been found yet

LivingEntity targets holding tridents with enchantment glint also cause a crash

Seems like both ItemRenderer#getArmorGlintConsumer and ItemRenderer#getDynamicDisplayGlintConsumer cause it

ItemRenderer#getItemGlintConsumer looks like it should also crash, but it doesn't probably because of the no-op consumer special case in WireframeEntityRenderer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash Oopsie
Projects
None yet
Development

No branches or pull requests

1 participant