Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip multiple matchs that require user intervention #144

Open
morsok opened this issue Sep 26, 2024 · 1 comment
Open

Add option to skip multiple matchs that require user intervention #144

morsok opened this issue Sep 26, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@morsok
Copy link

morsok commented Sep 26, 2024

Describe the bug A clear and concise description of what the bug is.

With only the -o option I expected that it would never hang and ask things interactively. If it needed input without the -i flag I expect it to say can't find a match, run with -i next time

To Reproduce Steps to reproduce the behavior:

metron-tagger --online my-comic.cbz

Expected behavior A clear and concise description of what you expected to
happen.

If it needed input without the -i flag I expect it to say can't find a match, run with -i next time

Screenshots If applicable, add screenshots to help explain your problem.

image
@bpepple
Copy link
Member

bpepple commented Sep 27, 2024

That's the expected behavior, since our common use-case is the user wants to tag the comics with one call. And the interactive flag is used when the user wants to approve all matchs (in particular for TPB which a lot of the time have the same cover as an individual issue) in a session

What you're describing is more a power-user use-case where they are running it in a terminal multiplexer or background command, which currently isn't supported. It's simple enough to implement (probably a total for 5 lines over 3 python modules). The toughest thing about it would what flag to use for it.

I'll look at adding it, but not sure when I'll get some free time to do it.

@bpepple bpepple changed the title Metron-tagger ask for user choice even when not setting the interactive flag Add option to skip multiple matchs that require user intervention Sep 27, 2024
@bpepple bpepple self-assigned this Sep 27, 2024
@bpepple bpepple added the enhancement New feature or request label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants