From 60254f7d08f48345b94bdb8cbf7a369467601f94 Mon Sep 17 00:00:00 2001 From: Michael Aquilina Date: Sun, 13 Oct 2019 10:42:24 +0100 Subject: [PATCH] Revert "Fix issue #79 - expand aliases to detect potentially better ones" This reverts commit a0ee820de8e2f3ae3e56d9b692b159c5469d9f6d. --- tests/test_aliases.zunit | 6 +++--- you-should-use.plugin.zsh | 5 +---- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/tests/test_aliases.zunit b/tests/test_aliases.zunit index 4a27a84..521c6b0 100644 --- a/tests/test_aliases.zunit +++ b/tests/test_aliases.zunit @@ -133,11 +133,11 @@ assert $state equals 0 } -@test 'expands aliases to find potentially better matches' { +@test 'issue 79 - expands aliases' { alias gd='git diff' alias gdw='git diff --word-diff' - run _check_aliases "gd --word-diff" "git diff --word-diff" + run _check_aliases "gd --word-diff" assert $output contains 'You should use: "gdw"' assert $state equals 0 -} +} \ No newline at end of file diff --git a/you-should-use.plugin.zsh b/you-should-use.plugin.zsh index 1eaff06..3052c12 100644 --- a/you-should-use.plugin.zsh +++ b/you-should-use.plugin.zsh @@ -191,10 +191,7 @@ function _check_aliases() { continue fi - if [[ "$typed" = "$value" || \ - "$typed" = "$value "* || - "$expanded" = "$value" || \ - "$expanded" = "$value "* ]]; then + if [[ "$typed" = "$value" || "$typed" = "$value "* ]]; then # if the alias longer or the same length as its command # we assume that it is there to cater for typos.