Support for abbreviations #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this ready to be merged? |
AtifChy
reviewed
Jul 28, 2024
| @@ -111,7 +127,6 @@ You should use: ${PURPLE}\"%alias\"${NONE}" | |||
| _write_ysu_buffer "$MESSAGE\n" | |||
There was a problem hiding this comment.
_write_ysu_buffer prints an empty line when $MESSAGE is empty
Suggested change
| _write_ysu_buffer "$MESSAGE\n" | |
| [[ -n $MESSAGE ]] && _write_ysu_buffer "$MESSAGE\n" |
this should go here
|
Additionally, I've observed that it displays the abbreviation tip message, whether or not an abbreviation is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to show what alias you just used is aliased to (more like a "you used" opposite of "you should use" in case you forget you keep using aliases
Solves #129
Split off from #131
Can be disabled easily with
zstyle ':you-should-use:' you_should_use_alias_enabled false
zstyle ':you-should-use:*' you_should_use_abbreviation_enabled false
Also added something that I think makes sense
-local limit="${1:-9000000000000000}"
+local limit="${1:-$HISTSIZE}"