Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is a DoS attack and not DDoS #1771

Open
kasir-barati opened this issue Dec 30, 2024 · 1 comment
Open

It is a DoS attack and not DDoS #1771

kasir-barati opened this issue Dec 30, 2024 · 1 comment
Labels
Community 👨‍👧 Something initiated by a community Documentation 📖 Issues about docs

Comments

@kasir-barati
Copy link

Describe the issue

So here is my two cent, AFAIK query complexity is related to DoS attack. So why here it says DDoS?

https://typegraphql.com/docs/complexity.html

Are you able to make a PR that fix this?

Not now TBF. My plate is too full 😅.

Additional context

Here I am adding a couple of links, to make my point more clear:

These all refer to this as DoS

@MichalLytek
Copy link
Owner

I think that the issue with 21223354 nested fields in a cycle fashion is more efficient as an attack if done by multiple hosts, not a single query run by a developer.

But yeah, I agree it technically should be named DoS. Feel free to submit a PR with a fix 😉

@MichalLytek MichalLytek added Community 👨‍👧 Something initiated by a community Documentation 📖 Issues about docs labels Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community 👨‍👧 Something initiated by a community Documentation 📖 Issues about docs
Projects
None yet
Development

No branches or pull requests

2 participants