Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steps should have Evidence sub-objects #7

Closed
LeeBergstrand opened this issue Oct 14, 2017 · 2 comments
Closed

Steps should have Evidence sub-objects #7

LeeBergstrand opened this issue Oct 14, 2017 · 2 comments

Comments

@LeeBergstrand
Copy link
Collaborator

LeeBergstrand commented Oct 14, 2017

Problem Description

Currently steps can have multiple pieces of evidence supporting them. These are marked by separate EV and TG tags.

For example:

--
SN  5
ID  N-(5'phosphoribosyl)anthranilate isomerase
DN  N-(5'phosphoribosyl)anthranilate isomerase (EC 5.3.1.24)
RQ  1
EV  IPR001240; PF00697; sufficient;
TG  GO:0000162;
EV  IPR010188; TIGR01919; sufficient;
TG  GO:0000162;

In the current system we do a preprocessing pass that collapses the EV and TG tags to a single tag per step.

EV  C1
TG  C2  ==== Goes To ====>> EV C1; C3;
EV  C3                                           TG C2; C4;
EV  C4

Problem Solution:

Each set of EV and TG should be pulled out into their own EVIDENCE object. Note: The sufficient key word means that that piece of evidence alone proofs that the that step exists (Ref: ebi-pf-team/genome-properties#30).

@LeeBergstrand LeeBergstrand self-assigned this Oct 14, 2017
@LeeBergstrand
Copy link
Collaborator Author

The plan is to wait for genome properties to solidify their flat file format with respect to steps before pursuing this change.

See ebi-pf-team/genome-properties#29 and ebi-pf-team/genome-properties#31

@LeeBergstrand LeeBergstrand changed the title Steps should have evidence sub objects Steps should have evidence sub-objects Oct 14, 2017
@LeeBergstrand LeeBergstrand changed the title Steps should have evidence sub-objects Steps should have Evidence sub-objects Oct 14, 2017
@LeeBergstrand
Copy link
Collaborator Author

Done. Via #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant