Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYPO in lib/snapBi #77

Open
sasakiRoo opened this issue Oct 22, 2024 · 5 comments
Open

TYPO in lib/snapBi #77

sasakiRoo opened this issue Oct 22, 2024 · 5 comments

Comments

@sasakiRoo
Copy link

sasakiRoo commented Oct 22, 2024

previously https://github.com/Midtrans/midtrans-nodejs-client/issues/76 , i encountered an issue that my node module cannot find "SnapBiApiRequestor".

so i checked it myslef, and found out that this code from folder lib/snapBi
const SnapBiApiRequestor = require('./SnapBiApiRequestor');

this code create problem CANNOT FIND MODULE and needs to be fixed, so that user dont need to fix it themselve.

expected code:
const SnapBiApiRequestor = require('./snapBiApiRequestor');

https://github.com/Midtrans/midtrans-nodejs-client/blob/master/lib/SnapBi/snapBi.js

@uziwuzzy
Copy link
Collaborator

thanks for the feedback, what version is this? ah I see, so there's a wrong capitalization ya? the s should be lowercase?

@sasakiRoo
Copy link
Author

Yes, it should be lowercase

@TacoFury
Copy link

let snap = new midtransClient.Snap({
^

TypeError: midtransClient.Snap is not a constructor

how to fix

@sasakiRoo
Copy link
Author

Coba kayak gini pas importnya.
import {Midtrans} from 'midtrans-client'

`let snap = new Midtrans.Snap({

})`

@sasakiRoo
Copy link
Author

NOTE: THE ISSUE OF UPPERCASE in SnapBiApiRequestor still is not fixed yet when i use netlify to test my app, it got error like the issue of number 76.

I created a pull request about fixing the typo. I hope it will be approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants