-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liquid syntax error: Unknown tag 'pdf' on build #7
Comments
Hello @guslipkin. Thank you for using this plugin. GitHub does not support all plugins. According to the docs:
See #1 for more detailed explanation There is a workaround. You can use jekyll-deploy-action to deploy your Jekyll site with any plugin. Here is my implementation. |
Hi, I met with the same problem, but the error remained after I followed the instruction. |
Hi @liver121888, |
Ok, this is very weird. <style> .pdf-embed-wrap-87f43424-063f-4e2e-8f19-5bdf01cb7be0 { display:flex; flex-direction: column; width: 100%; height: 650px; } .pdf-embed-container-87f43424-063f-4e2e-8f19-5bdf01cb7be0 { height: 100%; } .pdf-link-87f43424-063f-4e2e-8f19-5bdf01cb7be0 { background-color: white; text-align: center; border-style: solid; } .pdf-embed-container-87f43424-063f-4e2e-8f19-5bdf01cb7be0 iframe { width: 100%; height: 100%; } </style>
<div class="pdf-embed-wrap-87f43424-063f-4e2e-8f19-5bdf01cb7be0"> <div class="pdf-link-87f43424-063f-4e2e-8f19-5bdf01cb7be0"> <a href="https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf" target="_blank">View PDF</a> </div> <div class="pdf-embed-container-87f43424-063f-4e2e-8f19-5bdf01cb7be0"> <iframe src="https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf" frameborder="0" allowfullscreen=""></iframe> </div> </div> Will this information help you understand the problem? |
Also, if I want to link to a pdf that's in another repository, the link seems not working. |
My workaround for this problem is to publish that repo as a site under my github.io. Hope this helps those who want to access files in a different repo. |
@liver121888 As for the other issue, it is regarding your deployment, and not this plugin |
I am locking this conversation because the purpose of it is to show what the issue with GitHub is and how to deploy your Jekyll site with this plugin, and not fixing other people's code. Thank you |
Hello. I was really excited to find and implement this and was able to do so pretty quickly, but for a few small errors.
If I tried to install with
gem install jekyll-pdf-embed
I would get an error thatWhen I changed to using
it works locally just fine. However, when I upload to GitHub and go to deploy, neither method works and I get the same error.
The text was updated successfully, but these errors were encountered: