[✨ Triage] dotnet/aspire#11692 by KalleOlaviNiemitalo - Dashboard metrics filters do not take effect while metrics a ... #1544
Description
Triage for dotnet/aspire#11692.
Repo filter: area-dashboard issues.
MihuBot version: 554101.
Ping MihaZupan for any issues.
This is a test triage report generated by AI, aimed at helping the triage team quickly identify past issues/PRs that may be related.
Take any conclusions with a large grain of salt.
Tool logs
dotnet/aspire#11692: Dashboard metrics filters do not take effect while metrics are paused by KalleOlaviNiemitalo
[Tool] Searching for dashboard metrics filters paused, metrics filters not updating, dashboard graph filters, metrics pause button, metrics graph not updating filters (IncludeOpen=True, IncludeClosed=True, IncludeIssues=True, IncludePullRequests=True, Repository=dotnet/aspire)
[Tool] Found 67 issues, 210 comments, 40 returned results (7595 ms)
Here are related issues and discussions for issue #11692 "Dashboard metrics filters do not take effect while metrics are paused":
1. Issue #7610 (Feb 2025) - "Pause/resume button on console logs, structured logs, traces and metrics"
- Summary: This issue proposed adding pause buttons to various dashboard pages, including metrics. It discusses two approaches: pausing data reception (discarding new data while paused) vs. pausing the UI (freezing the display at a point in time and filtering out data after that). It notes that the metrics page graphs would need to stop updating the X axis with the current time when paused.
- Relevance: Directly related to the pause functionality and its effect on UI updates, including graphs and filters. It does not specifically address filter behavior while paused, but sets the context for the feature.
2. PR #8184 (Mar 2025) - "Add a pause button to console logs, structured logs, traces, and metrics pages"
- Summary: Implements the pause/resume button for multiple dashboard pages. For metrics, the X axis of the graph stays consistent during a pause. The discussion includes design decisions about whether pause should affect UI only or telemetry collection, and notes that the graph stops updating while paused, but navigating away and back updates the time.
- Comments: There is a suggestion that the pause manager should track when metrics were paused so that the "current time" for rendering is correct. There is no explicit mention of filter behavior while paused, but the implementation focuses on freezing the graph/UI.
- Relevance: This is the implementation of the pause feature, but does not address filter updates during pause.
3. Issue #348 (Oct 2023, closed Mar 2025) - "Dashboard: Metrics: Need a pause/resume button"
- Summary: Early discussion of the need for a pause/resume button, with debate about whether pause should be global or per-page, and whether it should stop data collection or just freeze the UI. The expected behavior is that the graph stops moving forward in time when paused.
- Comments: The issue was closed as a duplicate of #7610.
- Relevance: Sets expectations for pause behavior, but does not discuss filter updates during pause.
4. PR #9207 (May 2025) - "Add pause warning to metrics"
- Summary: Adds a visual warning to the metrics page when paused, making it clear to users. The warning is displayed under the graph for consistency with other pages.
- Relevance: Improves UI feedback for the pause state, but does not address filter behavior.
5. Issue #8457 (Apr 2025, closed May 2025) - "[WebToolsE2E][Aspire] There isn't a notification message display when you clicked the 'Pause button' in the Metrics Page."
- Summary: Reports that no notification is shown when pausing metrics. Fixed in Aspire 9.3.0-preview.1.25262.21.
- Relevance: UI feedback for pause, not filter logic.
6. Issue #1260 (Dec 2023, closed) and PR #1327 (Dec 2023) - "Metrics: Improve UI for selecting metrics filter"
- Summary: Improves the filter UI for metrics, replacing autocomplete with badges, overflow, button, popup, and checkboxes. New dimensions and values are automatically selected.
- Relevance: Related to filter UI and selection, but not to filter behavior while paused.
7. Issue #3126 (Mar 2024) - "Hide nonexistent combinations when filtering metrics on dashboard"
- Summary: Suggests that the dashboard should indicate which filter combinations are valid, to avoid selecting filters that exclude all measurements.
- Relevance: Related to filter usability, not to pause behavior.
8. Issue #3137 (Mar 2024) - "Dashboard metrics filter popup extends beyond browser window and disappears when I try to scroll the page"
- Summary: Reports a UI bug with the filter popup, not related to pause.
9. PR #1755 (Jan-Feb 2024) - "Add data grid view of metrics"
- Summary: Adds a table view for metrics, with various improvements and bug fixes. There is extensive discussion about how the table and graph should be kept in sync, including filter and time window logic.
- Comments: There is mention of the need to synchronize the chart and table views, and that the table should reflect the same data as the graph, including filters and time window. There is also discussion about how data updates and disappears as the time window moves.
- Relevance: While not directly about pause, this PR and its comments discuss the relationship between filters, time windows, and UI updates. It suggests that changing the time window forces a refresh and corrects filter application, which matches the workaround described in issue #11692.
10. Issue #2365 (Feb 2024, closed) - "Metrics table view selected isn't remembered when coming back to metrics"
- Summary: Persistence of table/graph view selection, not filter logic.
11. PR #5522 (Sep 2024) - "Fix various bugs in dashboard metrics"
- Summary: Fixes minor bugs in metrics, including persistence of duration and view selection, and JS errors when navigating away.
- Relevance: Not directly related to pause/filter interaction.
Synthesis and Conclusion
- The pause/resume feature for metrics was discussed and implemented in #7610 and PR #8184, with the intended behavior being that the graph/UI freezes at the pause point and does not update with new data.
- The filter UI has been improved (PR #1327), but there is no explicit discussion in any issue or PR about the expected behavior of filters while paused.
- The behavior described in #11692—where changing filters while paused does not immediately update the graph/table, but changing the time window does—matches the workaround discussed in PR #1755, where time window changes force a refresh.
- There is no existing issue or comment that directly addresses or resolves the bug described in #11692. It appears to be a new, unreported edge case in the interaction between pause state and filter application.
Recommendation
- Issue #11692 is not a duplicate and describes a real bug: while metrics are paused, changing filters does not immediately update the graph/table, but changing the time window does.
- The closest related discussions are in PR #1755, which describes how time window changes force a refresh, and in the pause feature issues/PRs, which do not address filter logic.
- This issue should be triaged as a bug in the metrics page's filter refresh logic while paused. It may require changes so that filter updates trigger a refresh of the graph/table even when paused.
Related issues and PRs:
- #7610 (Feb 2025) - Pause/resume button feature proposal
- #8184 (Mar 2025) - Pause button implementation
- #1755 (Jan-Feb 2024) - Metrics table/graph sync and refresh logic
- #1327 (Dec 2023) - Metrics filter UI improvements
No existing issue or PR directly addresses the filter refresh bug while paused. This is a new, valid bug report.