Skip to content
This repository has been archived by the owner on Dec 18, 2020. It is now read-only.

Support the view-source: source code views. #69

Open
chrisjj opened this issue Nov 20, 2016 · 9 comments
Open

Support the view-source: source code views. #69

chrisjj opened this issue Nov 20, 2016 · 9 comments
Milestone

Comments

@chrisjj
Copy link

chrisjj commented Nov 20, 2016

I'm getting no auto-update on view-source:file:// tabs.

file:// tabs are working fine.

Any remedy?

@MikeRogers0
Copy link
Owner

'view-source:file://' is currently not supported unfortunately. I'll have an experiment this week to see if adding support is possible :)

@MikeRogers0
Copy link
Owner

Out of interest why wouldn't making the 'file://' live not handle your use case?

@chrisjj
Copy link
Author

chrisjj commented Nov 20, 2016

I'm getting no auto-update on view-source:file:// tabs.

Misleading report. Sorry. In truth, LiveUpdate responds with a very clear statement:

image.

Thanks.

I'll have an experiment this week to see if adding support is possible :)

Great! I'll look forward to trying it.

Out of interest why wouldn't making the 'file://' live not handle your use case?

I'm adjusting a PHP source, rebulding, and in the browser verifying the effect on non-render items such as data- attributes... using view-source.

@MikeRogers0
Copy link
Owner

Oh that use case makes a lot of sense @chrisjj - I'll adjust the title to make this a feature :D

@MikeRogers0 MikeRogers0 added this to the 2.4.0 milestone Nov 21, 2016
@MikeRogers0 MikeRogers0 changed the title 2.11 Fail on view-source:file:// Support the view-source: source code views. Nov 21, 2016
@chrisjj
Copy link
Author

chrisjj commented Nov 22, 2016

Thanks! That'll save me a few thousand ALT+TAB, CTRL+Rs :-)

@MikeRogers0
Copy link
Owner

This might take me a bit longer to implement as it appears I can't inject JS into the view-source: pages like I normally would. However I believe I might have found a suitable solution (Doing the XHR request in the extension context), as a result it might take be a bit longer to implement.

@chrisjj
Copy link
Author

chrisjj commented Dec 4, 2016

Thanks. I'm patient :)

@MikeRogers0 MikeRogers0 modified the milestones: 2.5.0, 2.4.0 Dec 13, 2016
@MikeRogers0
Copy link
Owner

MikeRogers0 commented Dec 13, 2016

Timing for this, I've moved it to 2.5.0 to prioritise #74 . I'm aiming to finish 2.4.0 over Christmas & 2.5.0 in February.

@chrisjj
Copy link
Author

chrisjj commented Dec 13, 2016

Sounds appropriate to me :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants