[ Feat ] Default 모달, FullBtn 모달 반응형 #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
namdaeun
approved these changes
Dec 7, 2024
| @@ -57,15 +58,15 @@ export const DefaultModal = (props: ModalPropType) => { | |||
| const getModalImg = () => { | |||
| switch (modalImg) { | |||
| case 'POST': | |||
| return <img src={alertUploadPng} />; | |||
| return <ModalImg src={alertUploadPng} />; | |||
There was a problem hiding this comment.
P3) 사소한 부분이지만 alt 속성 추가해서 어떤 이미지인지 알려주면 좋을 것 같슴니다 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 해당 이슈 번호 ✨
closes #487
todo
📌 내가 알게 된 부분
📌 질문할 부분
📌스크린샷(선택)
2024-12-07.9.26.26.mov
2024-12-07.9.26.45.mov
2024-12-07.9.27.50.mov