Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

related_transactions in the SearchTransactionsResponse of Rosetta vs. MinaMesh #48

Open
piotr-iohk opened this issue Oct 8, 2024 · 0 comments

Comments

@piotr-iohk
Copy link
Collaborator

piotr-iohk commented Oct 8, 2024

When working on /search/transactions I've noticed that there is a difference in how empty related_transactions is presented in SearchTransactionsResponse in Rosetta vs. MinaMesh. In Rosetta empty related_transactions field is presented as:

"related_transactions": [],

In MinaMesh, in case of related_transactions: None the related_transactions is not serialized into the response at all.

RelatedTransaction is part of Transaction type, which is part of SearchTransactionsResponse. I suppose if we wanted to have the same behaviour we would need to serialize it to empty array when None via custom serialization behavior in https://github.com/harrysolovay/coinbase-mesh/blob/main/src/models/transaction.rs#L21.

@piotr-iohk piotr-iohk changed the title related_operations in the SearchTransactionsResponse of Rosetta vs. MinaMesh related_transactions in the SearchTransactionsResponse of Rosetta vs. MinaMesh Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant