test: fix tests #6
Conversation
miquelbeltran
requested review from
a team,
nikz,
TheRealAgentK and
sumitramanga
and removed request for
a team
| @@ -191,7 +191,7 @@ internal EnvironmentDetails(BrowserSpecs specs, BrowserStats stats) | |||
| DeviceName = !string.IsNullOrWhiteSpace(specs.DeviceName) ? specs.DeviceName : null; ; | |||
| Locale = specs.Locale; | |||
| OSVersion = !string.IsNullOrWhiteSpace(specs.UAHints?.CalculatedOSVersion) ? specs.UAHints.CalculatedOSVersion : specs.CalculatedOSVersion; | |||
| Platform = specs.UAHints.CalculatedPlatform ?? specs.Platform; | |||
| Platform = specs.UAHints?.CalculatedPlatform ?? specs.Platform; | |||
There was a problem hiding this comment.
The IDE also displayed a warning here saying that UAHints could be null. One of the tests failed due to it being null too.
| using Microsoft.Extensions.DependencyInjection; | ||
| using Microsoft.VisualStudio.TestTools.UnitTesting; | ||
|
|
||
| namespace Raygun4Net.Tests.Blazor.WebAssembly | ||
| namespace Raygun.NetCore.Tests.Blazor.WebAssembly |
There was a problem hiding this comment.
This was a recommendation by the IDE, to match the namespace definition with the folder name.
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "Raygun": { | |||
| "ApiKey": "APIKEY" | |||
There was a problem hiding this comment.
Tests failed to initialize because the appsettings.json was missing this key and so the init method threw an exception.
| @@ -36,7 +36,7 @@ internal record RequestDetails | |||
| /// The HTTP method used to request the URL (GET, POST, PUT, etc). | |||
| /// </summary> | |||
| [JsonInclude] | |||
| public HttpMethod HttpMethod { get; set; } | |||
| public string HttpMethod { get; set; } | |||
There was a problem hiding this comment.
This was a bit strange, not sure if it was a typo or on purpose. The JSON parser failed trying to convert this. The rest of the code did not complain after the change.
The warnings are fixed on a different PR. #12 |
* ci: dotnet formatting * simplify job * test break formatting * fix format * dotnet format
Test were broken for several reasons, some fixes required changing the client code, some fixing the test setup.
JSInteropmocks was missing, which caused tests to fail.Besides, I need to check how to fix the code formatting with some rules, so it doesn't change each time I modify a file.