make a new 0.4.1 bug-fix release #142

sezero · 2016-06-25T14:18:08Z

We should make a 0.4.1 followup bugfix release:
One bug I fixed is commit 335dc04.
Bug #141 stands out, which is waiting for @chrisisonwildcode

The text was updated successfully, but these errors were encountered:

psi29a · 2016-06-25T22:30:10Z

Sure, when @chrisisonwildcode fixes that we should do a 0.4.1

I'm awaiting debian/ubuntu to flood us with bugs as well.

psi29a · 2016-07-18T06:23:35Z

After #141 is fixed, should we do a 0.4.1 release or wait a bit more?

sezero · 2016-07-19T06:22:21Z

Don't have strong opinion for it.

chrisisonwildcode · 2016-07-19T19:02:01Z

Wait a bit more.

I've looked through the code and saw nothing obvious, as in the code paths for selecting a song within a multi-song file show no obvious errors. I'll be looking at the files that were sent later today and if they show nothing we've missed then I'll be gdbing the thing and tracing what's going on.

At the very least I'll have an answer today, at most a fix.

Sent from my iPhone

On 19 Jul 2016, at 4:22 PM, sezero [email protected] wrote:

Don't have strong opinion for it.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

psi29a · 2016-07-20T06:37:30Z

BTW: afritz1/OpenTESArena#38 (comment)

Most of this was answered by Chris/Kcat (OpenAL-Soft dev), please give it a once over to see if he was correct? It implies that XMI support is only partial because it doesn't support a translation of XMI's looping mechanism.

There are at least 2 files that seem to go on forever. One with 4~5m pause and another with an hour pause.

Apparently freepats has missing instruments which might cause problems for other users of WildMIDI.

chrisisonwildcode · 2016-07-20T22:32:47Z

I'm going to look into this. I'm sure we can support xmi loops converted into custom midi instructions ... Aka meta events ... Or even custom controller everts.

If it can be pulled off the way I'm thinking then XMI's converted to MIDI via wildmidi would playback converted xmi loops as loops. Of course we'd need an option to ignore/enable loops for sanity.

Thoughts?

Sent from my iPhone

On 20 Jul 2016, at 4:37 PM, Bret Curtis [email protected] wrote:

BTW: afritz1/OpenTESArena#38 (comment)

Most of this was answered by Chris/Kcat (OpenAL-Soft dev), please give it a once over to see if he was correct? It implies that XMI support is only partial because it doesn't support a translation of XMI's looping mechanism.

There are at least 2 files that seem to go on forever. One with 4~5m pause and another with an hour pause.

Apparently freepats has missing instruments which might cause problems for other users of WildMIDI.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

chrisisonwildcode · 2016-07-20T23:55:26Z

I can add support for xmidi controllers 116 & 117 and have WildMIDI support those from its midi output. But we're going to need a "gate keeper" for the midi output due to those controllers being undefined in midi and therefore ignored by default to avoid undesirable behaviours. We could add a text meta event "XMIDI" to be that gate keeper at the start of the file to denote xmidi controllers 116 & 117 be enabled.

Again thoughts

psi29a · 2016-07-25T10:21:17Z

Possibly related? #146

Looks like there are some unimplemented (looping based) MIDI messages/events.

psi29a · 2016-08-08T13:32:23Z

From doing my work with OpenBSD, it told me the following:

Scanning dependencies of target wildmidi
[ 90%] Building C object src/CMakeFiles/wildmidi.dir/wm_tty.c.o
[ 95%] Building C object src/CMakeFiles/wildmidi.dir/wildmidi.c.o
[100%] Linking C executable ../wildmidi
CMakeFiles/wildmidi.dir/wildmidi.c.o: In function `open_oss_output':
/home/psi29a/WildMIDI/wildmidi/src/wildmidi.c:1052: warning: warning: strcpy() is almost always misused, please use strlcpy()
/home/psi29a/WildMIDI/build/libWildMidi.so.2.0: warning: warning: vsprintf() is often misused, please use vsnprintf()
/home/psi29a/WildMIDI/build/libWildMidi.so.2.0: warning: warning: strcat() is almost always misused, please use strlcat()
/home/psi29a/WildMIDI/build/libWildMidi.so.2.0: warning: warning: sprintf() is often misused, please use snprintf()
[100%] Built target wildmidi

Something to worry about? Good advise? Will we break something?

sezero · 2016-08-08T13:36:42Z

strlcat warning is an openbsd advice. The rest are common advice. If we are manipulating our buffers correctly, then there is nothing to worry about. (That also means that it wouldn't hurt revisiting those parts of the code and revising.)

psi29a · 2016-08-16T10:31:40Z

Great news: https://buildd.debian.org/status/package.php?p=wildmidi

0.4.0 is finally uploaded to debian and it is built on all known platforms! (note, no tests were performed other than being built)

sezero · 2016-08-16T10:49:01Z

On 8/16/16, Bret Curtis [email protected] wrote:

Great news: https://buildd.debian.org/status/package.php?p=wildmidi

0.4.0 is finally uploaded to debian and it is built on all known platforms!
(note, no tests were performed other than being built)

Are packages depending on libwildmidi proted properly too?
The big endian target will be affected most importantly.

psi29a · 2016-08-16T10:55:59Z

Slomo (Debian) knows of the API changes, so that has been taken care of for us.

To be fair, this is a downstream issue, but it is good to let them know ahead of time. ;)

sezero · 2016-10-02T08:20:32Z

Should we make a 0.4.1 release? None of the open bug reports are regressions, including #141, already.

chrisisonwildcode · 2016-10-03T07:00:07Z

Sorry for delays, life and all that comes with it.

I'll be looking into features and bugs this week as I will have plenty of time on my hands. Hope to resolve at least #146 #149 #158

Chris

Sent from my iPhone

On 2 Oct. 2016, at 6:20 pm, sezero [email protected] wrote:

Should we make a 0.4.1 release? None of the open bug reports are regressions, including #141, already.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

psi29a · 2016-10-03T09:43:27Z

rejoice! :)

psi29a · 2016-10-03T09:44:50Z

I'm looking to, with @sezero blessing, begin work on on unsf integration so that we have some support for sf2. This will likely be for 0.4.2 unless 0.4.1 is still not yet released by the time I'm ready to merge. ;)

sezero · 2016-10-03T10:25:33Z

On 10/3/16, Bret Curtis [email protected] wrote:

I'm looking to, with @sezero blessing, begin work on on unsf integration so
that we have some support for sf2. This will likely be for 0.4.2 unless
0.4.1 is still not yet released by the time I'm ready to merge. ;)

My blessing (oh boy..) is irrelevant, but there is an inherent
issue with unsf as it is, which you know too: it wants to extract
the whole thing into files, bu we want to get the only samples
we want in a memory area. unsf shall need modifying heavily
for it.

psi29a · 2016-10-03T13:01:19Z

I was just trying to be funny. ;)

Three things:

once the whole soundfont is extracted, we don't need to do it again. This is why I implemented the -o flag, so that we can dump it to /tmp (or other directory dependent on OS). This creates the cfg file that will be read into wildmidi.
specifically asking for a patch/sample is on my todo list, but as an additional API call that gives a memory buffer location. So we would then explictely need to call open and close APIs. This is a lot more work, but worth it.
unsf isn't a replacement for native support for sf2, just a stop-gap. it was always my intention, at least in the beginning, to unpack the whole soundfont.

sezero · 2016-11-24T06:36:44Z

Any chance that we'll see those bug fixes? Or should we make a bugfix release from what we already have?

psi29a · 2016-11-24T08:04:58Z

@chrisisonwildcode I think he was referring to #146 #149 #158

chrisisonwildcode · 2016-11-24T09:10:48Z

Yes, we will see these fixes on Sunday night (AEST). I have been really busy with life, I apologise for the delay.

…

Sent from my iPhone

On 24 Nov. 2016, at 6:04 pm, Bret Curtis ***@***.***> wrote: @chrisisonwildcode I think he was referring to #146 #149 #158 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

sezero · 2016-11-26T08:34:28Z

#149 and #158 are more important. #146 is a new feature which everybody can live (and have been living) without.

chrisisonwildcode · 2016-12-04T09:45:42Z

I am dedicating this week to get stuff happening. I must point out that fixing devtest has been a priority due to it having timing issues making it harder to debug formats.

Plan is to:

Fix devtest (fix timing issue to make debugging formats easier)
Fix playback of xmi loops
Implement midi event callback (note this will trigger on the event but before it is processed by WildMIDI)
Fix playback of other formats

Any other request for the next release then please speak up.

sezero · 2016-12-15T08:13:41Z

Do we have an ETA yet?

sezero · 2017-01-08T20:13:45Z

Will this take forever?

chrisisonwildcode · 2017-01-08T21:17:42Z

Hi, I do apologise. To be honest with myself I haven't had the motivation lately to do much. In saying that I am getting back on track however I am having an operation in a couple of days time. The recovery period after release from hospital will give me plenty of time to work on this. I will give you an eta of 3-6 weeks dependent on my recovery. Again sorry for the delay. Sincerely Chris

…

Sent from my iPhone

On 9 Jan 2017, at 6:13 am, sezero ***@***.***> wrote: Will this take forever? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

psi29a · 2017-01-09T08:19:26Z

Gives me time to sneak in some stuff. ;)

I'll keep myself busy with unsf. I want to get to the point where we can ask unsf for specific patches instead of dumping all of them at once.

sezero · 2017-03-17T07:25:24Z

Nothing is happening. Should we release what we have as 0.4.1 ?

chrisisonwildcode · 2017-03-17T10:05:05Z

Sorry, I know I keep saying that then something in my other life happens. If you want to release do so, I will be bug fixing as time allows. I have been working on stuff but have nothing ready. Chris

…

Sent from my iPhone

On 17 Mar 2017, at 5:25 pm, sezero ***@***.***> wrote: Nothing is happening. Should we release what we have as 0.4.1 ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

sezero · 2017-03-17T12:46:10Z

Made the 0.4.1 release; also created a new "0.4.2" milestone. Closing this one.

sezero added this to the 0.4.1 - Crank it up to 11 milestone Jun 25, 2016

afritz1 mentioned this issue Jul 27, 2016

Certain Arena XMI files do not loop correctly #149

Open

sezero closed this as completed Mar 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make a new 0.4.1 bug-fix release #142

make a new 0.4.1 bug-fix release #142

sezero commented Jun 25, 2016

psi29a commented Jun 25, 2016

psi29a commented Jul 18, 2016

sezero commented Jul 19, 2016

chrisisonwildcode commented Jul 19, 2016

psi29a commented Jul 20, 2016

chrisisonwildcode commented Jul 20, 2016

chrisisonwildcode commented Jul 20, 2016

psi29a commented Jul 25, 2016

psi29a commented Aug 8, 2016

sezero commented Aug 8, 2016 via email

psi29a commented Aug 16, 2016

sezero commented Aug 16, 2016

psi29a commented Aug 16, 2016 •

edited

Loading

sezero commented Oct 2, 2016

chrisisonwildcode commented Oct 3, 2016

psi29a commented Oct 3, 2016

psi29a commented Oct 3, 2016

sezero commented Oct 3, 2016

psi29a commented Oct 3, 2016

sezero commented Nov 24, 2016

psi29a commented Nov 24, 2016

chrisisonwildcode commented Nov 24, 2016 via email

sezero commented Nov 26, 2016

chrisisonwildcode commented Dec 4, 2016

sezero commented Dec 15, 2016

sezero commented Jan 8, 2017

chrisisonwildcode commented Jan 8, 2017 via email

psi29a commented Jan 9, 2017 •

edited

Loading

sezero commented Mar 17, 2017

chrisisonwildcode commented Mar 17, 2017 via email

sezero commented Mar 17, 2017

make a new 0.4.1 bug-fix release #142

make a new 0.4.1 bug-fix release #142

Comments

sezero commented Jun 25, 2016

psi29a commented Jun 25, 2016

psi29a commented Jul 18, 2016

sezero commented Jul 19, 2016

chrisisonwildcode commented Jul 19, 2016

psi29a commented Jul 20, 2016

chrisisonwildcode commented Jul 20, 2016

chrisisonwildcode commented Jul 20, 2016

psi29a commented Jul 25, 2016

psi29a commented Aug 8, 2016

sezero commented Aug 8, 2016 via email

psi29a commented Aug 16, 2016

sezero commented Aug 16, 2016

psi29a commented Aug 16, 2016 • edited Loading

sezero commented Oct 2, 2016

chrisisonwildcode commented Oct 3, 2016

psi29a commented Oct 3, 2016

psi29a commented Oct 3, 2016

sezero commented Oct 3, 2016

psi29a commented Oct 3, 2016

sezero commented Nov 24, 2016

psi29a commented Nov 24, 2016

chrisisonwildcode commented Nov 24, 2016 via email

sezero commented Nov 26, 2016

chrisisonwildcode commented Dec 4, 2016

sezero commented Dec 15, 2016

sezero commented Jan 8, 2017

chrisisonwildcode commented Jan 8, 2017 via email

psi29a commented Jan 9, 2017 • edited Loading

sezero commented Mar 17, 2017

chrisisonwildcode commented Mar 17, 2017 via email

sezero commented Mar 17, 2017

psi29a commented Aug 16, 2016 •

edited

Loading

psi29a commented Jan 9, 2017 •

edited

Loading