-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support per-channel configurable Markdown conversion #49
base: master
Are you sure you want to change the base?
Conversation
it is broken still; retains style for one more block
The purpose of this pr is to add markdown support directly in minecraft channel ? Or to support markdown text from other source like discord ? Just to be sure i understand :) |
This is supposed to convert Markdown in ingame Chat messages to Tellraw data; other sources such as Discord for example would imparatively need to parse markdown themselves. |
Can be good to look to add something like this for the parsing : https://github.com/Vankka/MCDiscordReserializer since it's process markdown from discord :) |
i agree about the polyfill class. however; for a couple of things used here (tellraw data, mc format codes and markdown conversion, and even already for rabbitmq connections), i have already collected a couple (and more) utility classes in my common api library
i think like you suggested, it would be good having a library for this. |
I prefer the "hard way" :D and maybe think about to refactor this part of the code to ease the maintenance of it and the readability . |
This PR adds support for Markdown conversion.