Skip to content

Request: update mcfunction linguist language to use syntax-mcfunction #17

Open
@TheAfroOfDoom

Description

@TheAfroOfDoom

Summary

A few years ago, @Arcensoth submitted and merged a PR that added language-mcfunction to linguist. This enabled syntax highlighting for .mcfunction files in GitHub! (among other things probably, idk)

github-linguist/linguist#4425

We should update linguist to instead use this repo (syntax-mcfunction) so we get more up-to-date highlighting when we push .mcfunctions.

I don't know the full extent of this, but since Arcensoth has already laid the groundwork I hope it should be relatively straightforward (probably just updating the submodule to point to syntax-mcfunction instead of language-mcfunction).

Basic Example

Some notable current syntax highlighting mishaps include the following cases, as well as whatever other mcfunction language features that have changed since language-mcfunction's last update:

  • macros show up as a full red line
  • line continuation doesn't work

Is this specific to a text editor?

Other (please specify above)

Other Info

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions