New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest Botania breaks Mana Repair (fix included) #9

Open

alexgurrola opened this issue Jun 22, 2020 · 0 comments

Assignees

alexgurrola commented Jun 22, 2020 •

edited

Loading

Problem:

Mana Repair doesn't work with latest Botania (tested with r1.10-363)

Bottom Line:

The function vazkii.botania.api.mana.ManaItemHandler.requestManaForTool() has moved to vazkii.botania.common.impl.mana.ManaItemHandlerImpl.requestManaForTool(), which breaks BotaniaHelper.java#L9.

Further Information:

The BotaniaHelper.java#L9 is pointed to ManaItemHandler.requestManaForTool().
In the latest Botania, the function ManaItemHandler.requestManaForTool() on ManaItemHandler.java#L113 is deprecated and always calls return 0.
The commit VazkiiMods/Botania@272ef5b on April 3 changed the location of this calculation to vazkii.botania.common.impl.mana.ManaItemHandlerImpl.requestManaForTool() on ManaItemHandlerImpl.java#L201

The text was updated successfully, but these errors were encountered:

alexgurrola changed the title ~~Latest Botania breaks Mana Repair~~ Latest Botania breaks Mana Repair (with probable fix)

alexgurrola changed the title ~~Latest Botania breaks Mana Repair (with probable fix)~~ Latest Botania breaks Mana Repair (fix included)

YaibaToKen self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment