Skip to content
This repository has been archived by the owner on Aug 20, 2020. It is now read-only.

[names_per_ip] update request #228

Open
aerozoic opened this issue Aug 1, 2017 · 7 comments
Open

[names_per_ip] update request #228

aerozoic opened this issue Aug 1, 2017 · 7 comments

Comments

@aerozoic
Copy link
Member

aerozoic commented Aug 1, 2017

I've had a request for the latest version of this mod, it has a whitelist feature to allow specific players/IP to exceed the account limit. Useful for players in large households. https://github.com/SmallJoker/names_per_ip
🔶

@Lymkwi
Copy link
Member

Lymkwi commented Sep 4, 2017

I'll have to change something in the code for compatibility after the first restart though. @Darcidride let me know when you update.

@Lymkwi Lymkwi reopened this Sep 4, 2017
@BetterToAutomateTheWorld
Copy link
Member

@LeMagnesium
I'm still waiting your "ok" to merge the server, i know you do some code job this last weeks and want to know when you're ready to merge it.
Im a little too busy currently to check the latest commits to understand the code

@Lymkwi
Copy link
Member

Lymkwi commented Sep 30, 2017

@Darcidride We could merge right now but maybe @ElementW would prefer finishing the Aerbratus nodes/items that aren't complete yet before we do.

@ElementW
Copy link
Member

@LeMagnesium Probably not. If anything, the mysql_ things are higher on my to-do list than the aerbratus and items alike

@aerozoic
Copy link
Member Author

aerozoic commented Sep 30, 2017

@Darcidride @LeMagnesium @ElementW Just because we could doesn't mean we should. Even though lvl 5 quests are "functional" it doesn't mean they are ready. Just my opinion but i think the merge should wait until things are done properly.
🔶

@BetterToAutomateTheWorld
Copy link
Member

@LeMagnesium @ElementW @aerozoic
I've no problem with the fact we need to wait a little before pushing this code to production :)

@Lymkwi
Copy link
Member

Lymkwi commented Feb 3, 2018

Now that you're here more often, @Darcidride, perhaps we could see together to close small issues like these which need small fixes and mod-specific merges (maybe we don't need to update skyblock along with names_per_ip). What do you think of it? (Apologies for being absent for so long, studies have been getting in the way)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants