Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Typescript Typings #9

Open
MingweiSamuel opened this issue Dec 28, 2019 · 6 comments
Open

Add Typescript Typings #9

MingweiSamuel opened this issue Dec 28, 2019 · 6 comments
Labels
enhancement

Comments

@MingweiSamuel
Copy link
Owner

TeemoJS is very javascript-ey, i.e. very untyped, but it would still be nice to provide typescript typings when possible.

https://gist.github.com/molenzwiebel/7bf64a4b79f609c4bae85f1db38ef08e
@Querijn
Copy link

Querijn commented Jan 13, 2020

Would like to see this. I'm exploring other options as a javascript Riot API library.

@MingweiSamuel
Copy link
Owner Author

Project is being rewritten in typescript now

@MingweiSamuel
Copy link
Owner Author

Version 3 (prerelease) now has full TypeScript typings
https://www.npmjs.com/package/teemojs/v/3.0.0-rc.1
https://github.com/MingweiSamuel/TeemoJS/tree/master#readme

@itryp
Copy link

itryp commented Jun 9, 2021

@MingweiSamuel thanks for your update, is the version 3 working with datadragon? and if yes, how should we proceed?

@MingweiSamuel
Copy link
Owner Author

MingweiSamuel commented Jun 9, 2021 •
edited
Loading

@itryp V3 doesn't have a ddragon config right now, but I can add one soon

@jbryant4
Copy link

jbryant4 commented Aug 8, 2021

@MingweiSamuel just following up with the ddragon config. Just wondering if it is working with teemoJs at the moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@itryp @Querijn @MingweiSamuel @jbryant4