Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fan RPM measure #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Fan RPM measure #35

wants to merge 2 commits into from

Conversation

wzub
Copy link

@wzub wzub commented Aug 30, 2020

This adds the Fan RPM to the GPU measure. Currently it's not dynamic so depending on whether you use MSI Afterburner or HWiNFO, you will need to change MeasureName3 under [Value5] in /Performance Templates/gpuTemplate.ini

The RPM are shown in a new line below the Temperature, which looks best in the Performance - Combo skin.

image

Possible improvements

  • Get Fan RPM data automatically
  • Show in one line on the standalone GPU skins to prevent overflowing text

To switch between Afterburner and HWiNFO, change MeasureName3 under [Value5]
Automatically detect GPU fan speed from HWiNFO or Afterburner, detect CPU fan speed from HWiNFO, and fixes to sizes and positioning of rpm measures
@wzub
Copy link
Author

wzub commented Aug 31, 2020

An alternative implementation was submitted by @clone1084 in PR #36 which also includes CPU fan RPM. Using that as a starting point I've made some improvements here

@wzub wzub mentioned this pull request Aug 31, 2020
@MinhThienDX MinhThienDX self-assigned this Sep 1, 2020
@Beguiled
Copy link

Beguiled commented Sep 1, 2020

Is the intention to combine these two PRs ( #35 / #36 ) into a single solution then? I'm liking the way both of these are going.

@wzub
Copy link
Author

wzub commented Sep 1, 2020

I've already absorbed #36 into this one (sorry @clone1084 😅) after seeing it had CPU fan speed as well. It works perfectly with HWiNFO, but MSI Afterburner apparently can't read CPU fan speed. The HWiNFOSensorId was also different for me, I'm not sure how we could automate that detection. Maybe @MinhThienDX can take a look and advise.

image
(note I've disabled the Disk monitor and made some edits to Network monitor in the Combo skin but those are not part of this PR)

@MinhThienDX MinhThienDX linked an issue Sep 5, 2020 that may be closed by this pull request
@ffpp2003
Copy link

ffpp2003 commented Jun 4, 2021

Im trying to do my own implementation of the fan speed of my cpu, and I cant get to a final solution. This is how i want it to look:
image

And this is where i'm at:
image

For some reason, i can't get the text to properly show in two lines. i tried using Text="#Fan1#: %1 #Unit#[\10]#Fan2#: %2 #Unit#", but it only shows the Pump: XXXX rpm part. i also tried using Text="#Fan1#: %1 #Unit##CRLF##Fan2#: %2 #Unit#", but i get the same results.
Appearently, i also cant get the Fan text to show up.
I'm not expert at Rainmeter nor Lua, but i kinda understand the logic. Thats how i got so far.
Here i drop the modded skin:
Win10 Widgets.zip
I added the next files:

@Resources\Performance Templates\fanTemplate.ini
Performance - Fan\Fan-Large.ini
Performance - Fan\Fan-Medium.ini
Performance - Fan\Fan-Small.ini
Performance - Fan\Fan-Tiny.ini

and i modded the next files:

@Resources\variables.ini at line 94 and 95
@Resources\Performance Templates\performanceTemplateX4.ini from line 60 to 65, from line 569 to 665
Performance - Combo\Combo.ini at line 42, 66, 67 and 68

I would like to have some help, but i dont know if this is the correct place to ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GPU fan RPM?
4 participants