Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for quality fallback #26

Open
popeye2468 opened this issue Jan 15, 2023 · 7 comments
Open

Add support for quality fallback #26

popeye2468 opened this issue Jan 15, 2023 · 7 comments

Comments

@popeye2468
Copy link

can you add support for quality fallback please
@MinisculeGirraffe
Copy link
Owner

I'm fairly certain this is already implemented. It will attempt to grab the quality specified and if it's not available it will return the highest available.

I'd have to do some testing to validate this behavior though as I can't remember the exact behavior.

@MinisculeGirraffe
Copy link
Owner

Can you provide an example of your expected behavior for reference also?

@popeye2468
Copy link
Author

i will randomly get an error saying EOF while parsing a value at line 1 column 0 but if i change the quality it then downloads

@popeye2468
Copy link
Author

it seems to not be downloading all tracks on first run, i have to repeat the command several times

@MinisculeGirraffe
Copy link
Owner

Hmm. It's probably their API returning a value that wasn't expected. Can you provide an example command?

@popeye2468
Copy link
Author

these are the albums that command shows up with they seem to download fine with tidal-dl i just prefer your one as its much much faster

i use tdl get followed by each album

https://listen.tidal.com/album/25710686 https://listen.tidal.com/album/99674505 https://listen.tidal.com/album/5247786 https://listen.tidal.com/album/77668838 https://listen.tidal.com/album/94504887 https://listen.tidal.com/album/25710725 https://listen.tidal.com/album/66547575 https://listen.tidal.com/album/127853440 https://listen.tidal.com/album/99556604 https://listen.tidal.com/album/85413521 https://listen.tidal.com/album/25710712 https://listen.tidal.com/album/99024816 https://listen.tidal.com/album/25710699 https://listen.tidal.com/album/25688984 https://listen.tidal.com/album/98416518 https://listen.tidal.com/album/26348389 https://listen.tidal.com/album/181542375 https://listen.tidal.com/album/95050310

@popeye2468
Copy link
Author

so i waited a short while and before i would do 2 or 3 albums at once and then i would get that error, however if i do each one seperate with a small pause about 5 secs between each album i dont get this error.

is there a way to implement a small pause between albums?

@cleonyc cleonyc mentioned this issue Jan 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@popeye2468 @MinisculeGirraffe