From eca7f870c56b1f21259a931dd2128fb4d5ee36a4 Mon Sep 17 00:00:00 2001 From: sebastienh Date: Fri, 8 Jul 2022 23:14:24 -0400 Subject: [PATCH 1/9] pylint disable missing docstring and fixme --- pylintrc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pylintrc b/pylintrc index 106fb97e2..fe1563321 100644 --- a/pylintrc +++ b/pylintrc @@ -155,7 +155,10 @@ disable=raw-checker-failed, useless-suppression, deprecated-pragma, use-symbolic-message-instead, - missing-module-docstring + missing-module-docstring, + missing-function-docstring, + missing-class-docstring, + fixme # Enable the message, report, category or checker with the given id(s). You can # either give multiple identifier separated by comma (,) or put this option From d60c8c9346dcb79ce85be3b4f52e1edc9685576c Mon Sep 17 00:00:00 2001 From: sebastienh Date: Fri, 8 Jul 2022 23:16:57 -0400 Subject: [PATCH 2/9] set release version --- geoapps/__init__.py | 2 +- pyproject.toml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/geoapps/__init__.py b/geoapps/__init__.py index 0b0f434ff..64e4fa4b6 100644 --- a/geoapps/__init__.py +++ b/geoapps/__init__.py @@ -5,4 +5,4 @@ # geoapps is distributed under the terms and conditions of the MIT License # (see LICENSE file at the root of this source code package). -__version__ = "0.8.0-alpha.2" +__version__ = "0.8.0" diff --git a/pyproject.toml b/pyproject.toml index 92d021d56..210d2b4df 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,6 @@ [tool.poetry] name = "geoapps" -version = "0.8.0-alpha.2" +version = "0.8.0" description = "Open-sourced Applications in Geoscience" authors = ["Mira Geoscience "] repository = "https://github.com/MiraGeoscience/geoapps" From 440d27f3ea131a0f9c90b636cc3d5a7c0dc3e2ec Mon Sep 17 00:00:00 2001 From: sebastienh Date: Mon, 11 Jul 2022 15:34:36 -0400 Subject: [PATCH 3/9] attempt to fix ReadTheDocs --- readthedocs.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/readthedocs.yml b/readthedocs.yml index cbe6fd670..4995d55a7 100644 --- a/readthedocs.yml +++ b/readthedocs.yml @@ -1,7 +1,11 @@ +version: 2 + python: - setup_py_install: true + install: + - method: pip + path: . conda: - file: docs/environment.yml + environment: docs/environment.yml sphinx: builder: html configuration: conf.py From e660503451c8f50dfd6bd430482fbf1e19010fab Mon Sep 17 00:00:00 2001 From: sebastienh Date: Mon, 11 Jul 2022 15:48:12 -0400 Subject: [PATCH 4/9] does readthedocs need geoapps to be installed? it already uses conda environment defined by docs/environment.yml --- readthedocs.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/readthedocs.yml b/readthedocs.yml index 4995d55a7..309f9cef9 100644 --- a/readthedocs.yml +++ b/readthedocs.yml @@ -1,9 +1,5 @@ version: 2 -python: - install: - - method: pip - path: . conda: environment: docs/environment.yml sphinx: From b27f18b5349c1efe39716447114c989156d76121 Mon Sep 17 00:00:00 2001 From: sebastienh Date: Mon, 11 Jul 2022 16:09:25 -0400 Subject: [PATCH 5/9] fix reference to doc configuration files --- readthedocs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/readthedocs.yml b/readthedocs.yml index 309f9cef9..11000ccb6 100644 --- a/readthedocs.yml +++ b/readthedocs.yml @@ -4,6 +4,6 @@ conda: environment: docs/environment.yml sphinx: builder: html - configuration: conf.py + configuration: docs/conf.py fail_on_warning: true formats: [] From f471745f27ca426e9131352c7f369bc3500fbef3 Mon Sep 17 00:00:00 2001 From: sebastienh Date: Mon, 11 Jul 2022 16:34:48 -0400 Subject: [PATCH 6/9] no need for geoh5py in the doc environment --- docs/environment.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/environment.yml b/docs/environment.yml index ac0714966..a4e911b1c 100644 --- a/docs/environment.yml +++ b/docs/environment.yml @@ -9,7 +9,6 @@ dependencies: - ipywidgets - ipykernel - pip: - - geoh5py==0.1.4 - numpydoc - jinja2==3.0.3 - sphinx==3.5.4 From c2fe0f7f5d978fe29af33e77dd9a11a7bc0dc69d Mon Sep 17 00:00:00 2001 From: sebastienh Date: Wed, 13 Jul 2022 14:56:54 -0400 Subject: [PATCH 7/9] make pylint fail on warnings too --- pylintrc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pylintrc b/pylintrc index fe1563321..d90899ebc 100644 --- a/pylintrc +++ b/pylintrc @@ -33,8 +33,7 @@ extension-pkg-whitelist= # Return non-zero exit code if any of these messages/categories are detected, # even if score is above --fail-under value. Syntax same as enable. Messages # specified are enabled, while categories only check already-enabled messages. -fail-on=E,F -# TODO: fail on warnings too (W) +fail-on=W,E,F # Specify a score threshold to be exceeded before program exits with error. # TODO: remove this. Only to ease transition to cleaner code From 7c80416d24c2931c3b4b81d346e4a02c19dc6c3f Mon Sep 17 00:00:00 2001 From: sebastienh Date: Wed, 13 Jul 2022 14:56:22 -0400 Subject: [PATCH 8/9] focus pylint report on errors for now --- pylintrc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pylintrc b/pylintrc index d90899ebc..59736bae6 100644 --- a/pylintrc +++ b/pylintrc @@ -157,7 +157,8 @@ disable=raw-checker-failed, missing-module-docstring, missing-function-docstring, missing-class-docstring, - fixme + fixme, + R,C,W # TODO: re-enable these # Enable the message, report, category or checker with the given id(s). You can # either give multiple identifier separated by comma (,) or put this option From 18e8ee48366906418e74a0365b0719c53ab9d7ca Mon Sep 17 00:00:00 2001 From: sebastienh Date: Wed, 13 Jul 2022 14:56:22 -0400 Subject: [PATCH 9/9] still interested in fixing pylint warnings --- pylintrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pylintrc b/pylintrc index 59736bae6..9a66200f6 100644 --- a/pylintrc +++ b/pylintrc @@ -158,7 +158,7 @@ disable=raw-checker-failed, missing-function-docstring, missing-class-docstring, fixme, - R,C,W # TODO: re-enable these + R,C # TODO: re-enable these # Enable the message, report, category or checker with the given id(s). You can # either give multiple identifier separated by comma (,) or put this option