Skip to content

Commit 7894457

Browse files
committed
use double equals for other NaN checks
1 parent f20c392 commit 7894457

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/compiler/jsexecute.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ baseRuntime += `const compareEqualSlow = (v1, v2) => {
278278
if (Number.isNaN(n2) || (n2 === 0 && isNotActuallyZero(v2))) return ('' + v1).toLowerCase() === ('' + v2).toLowerCase();
279279
return n1 === n2;
280280
};
281-
const compareEqual = (v1, v2) => (typeof v1 === 'number' && typeof v2 === 'number' && !Number.isNaN(v1) && !Number.isNaN(v2) || v1 === v2) ? v1 === v2 : compareEqualSlow(v1, v2);`;
281+
const compareEqual = (v1, v2) => (typeof v1 === 'number' && typeof v2 === 'number' && (v1 === v1) && (v2 === v1) || v1 === v2) ? v1 === v2 : compareEqualSlow(v1, v2);`;
282282

283283
/**
284284
* Determine if one value is greater than another.
@@ -301,7 +301,7 @@ runtimeFunctions.compareGreaterThan = `const compareGreaterThanSlow = (v1, v2) =
301301
}
302302
return n1 > n2;
303303
};
304-
const compareGreaterThan = (v1, v2) => typeof v1 === 'number' && typeof v2 === 'number' && !Number.isNaN(v2) ? v1 > v2 : compareGreaterThanSlow(v1, v2)`;
304+
const compareGreaterThan = (v1, v2) => typeof v1 === 'number' && typeof v2 === 'number' && (v2 === v2) ? v1 > v2 : compareGreaterThanSlow(v1, v2)`;
305305

306306
/**
307307
* Determine if one value is less than another.
@@ -324,7 +324,7 @@ runtimeFunctions.compareLessThan = `const compareLessThanSlow = (v1, v2) => {
324324
}
325325
return n1 < n2;
326326
};
327-
const compareLessThan = (v1, v2) => typeof v1 === 'number' && typeof v2 === 'number' && !Number.isNaN(v2) ? v1 < v2 : compareLessThanSlow(v1, v2)`;
327+
const compareLessThan = (v1, v2) => typeof v1 === 'number' && typeof v2 === 'number' && (v2 === v2) ? v1 < v2 : compareLessThanSlow(v1, v2)`;
328328

329329
/**
330330
* Generate a random integer.

0 commit comments

Comments
 (0)