From ace964de044aa280688ef63a27b819fda48058b2 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Mon, 23 Sep 2024 02:25:47 -0700 Subject: [PATCH] Just send a PR comment in case of missing dist folders Also, add missing variables to the `notify-triage.yml` workflow. --- .github/workflows/build.yml | 21 -------------------- .github/workflows/check-for-missing-dist.yml | 18 +++++++++++++++++ .github/workflows/notify-triage.yml | 3 +++ 3 files changed, 21 insertions(+), 21 deletions(-) delete mode 100644 .github/workflows/build.yml create mode 100644 .github/workflows/check-for-missing-dist.yml diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml deleted file mode 100644 index 7768e27..0000000 --- a/.github/workflows/build.yml +++ /dev/null @@ -1,21 +0,0 @@ -name: Build actions - -on: - push: - branches: [main] - -permissions: - contents: write - -jobs: - build: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - run: npm ci - - run: npx rollup --config - - run: git config --global user.name 'github-actions[bot]' - - run: git config --global user.email '41898282+github-actions[bot]@users.noreply.github.com' - - run: git add dist - - run: git commit --message 'Rebuild deploy action bundle' - - run: git push diff --git a/.github/workflows/check-for-missing-dist.yml b/.github/workflows/check-for-missing-dist.yml new file mode 100644 index 0000000..eb21467 --- /dev/null +++ b/.github/workflows/check-for-missing-dist.yml @@ -0,0 +1,18 @@ +name: Notify on missing dist update + +on: + pull_request_target: + branches: [main] + paths: ['lib', '!dist'] + +jobs: + complain: + runs-on: ubuntu-latest + steps: + - run: | + export GITHUB_TOKEN="$GH_TOKEN_SECRET" + gh pr review "$PR_URL" --request-changes --body "$MESSAGE" + env: + GITHUB_TOKEN: ${{ github.token }} + PR_URL: ${{ github.event.issue.url }} + MESSAGE: Don't forget to rebuild `dist/`. diff --git a/.github/workflows/notify-triage.yml b/.github/workflows/notify-triage.yml index fb31c64..2a32316 100644 --- a/.github/workflows/notify-triage.yml +++ b/.github/workflows/notify-triage.yml @@ -15,3 +15,6 @@ jobs: export GITHUB_TOKEN="$GH_TOKEN_SECRET" gh issue edit "$ISSUE_URL" --add-project 'Triage/bugs' && gh issue comment "$ISSUE_URL" --body '@MithrilJS/triage Please take a look.' + env: + GITHUB_TOKEN: ${{ github.token }} + ISSUE_URL: ${{ github.event.issue.url }}