Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

네이밍 규칙 관련 제안 #2

Open
bab2min opened this issue Sep 28, 2021 · 0 comments
Open

네이밍 규칙 관련 제안 #2

bab2min opened this issue Sep 28, 2021 · 0 comments

Comments

@bab2min
Copy link

bab2min commented Sep 28, 2021

전반적으로 PEP8 스타일에 맞춰 클래스나 메소드 명들이 잘 지어져 있으나, 일부 메소드의 argument에 대해서는 규칙이 좀 혼재되어 있는 것 같네요~ PEP8 규칙에 맞춰서 네이밍을 통일하면 더 좋을 것 같습니다.

def get_search_list(self, query, topicId=None, videoCaption=None, regionCode="KR", nextPageToken=None):

def youtube_search(self, query, topicId=None, videoCaption=None, regionCode="KR"):

def make_captions(self, df, is_En=False):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant