Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in observable binning attribute #54

Open
jkwinter opened this issue Nov 18, 2022 · 1 comment
Open

Bug in observable binning attribute #54

jkwinter opened this issue Nov 18, 2022 · 1 comment

Comments

@jkwinter
Copy link
Collaborator

Context:

trying to build 2D observables from existing 1D observables as such

Observable([obs1.name,obs2.name],f'{obs1.name}_{obs2.name}', binning = [obs1.binning,obs2.binning], dataset = 'thj_observables', label = f'{obs1.name} vs {obs2.name}')

returns error because obs1.binning returns a list instead of object of pythium binning class type

List index 0 item [<pythium.histogramming.binning.RegBin object at 0x7f5b55220bd0>] not instance of <class "pythium.histogramming.binning._Binning">.

In pythium.histogramming.objects.py -> self.binning converted to list if not provided as such

Temporary solution: use binnin = [obs1.binning[0], obs2.binning[0]]

@jkwinter
Copy link
Collaborator Author

This also affects self.var, self.labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant