Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add classes for various sets of systematics at Histogramming #6

Open
3 of 5 tasks
MoAly98 opened this issue Aug 27, 2021 · 1 comment
Open
3 of 5 tasks

Add classes for various sets of systematics at Histogramming #6

MoAly98 opened this issue Aug 27, 2021 · 1 comment
Assignees
@MoAly98
Labels
bug Something isn't working histogramming related to histogramming code

Comments

@MoAly98
Copy link
Owner

MoAly98 commented Aug 27, 2021 •
edited
Loading

We have various types of systematic uncertainties that need to be considered when building histograms:

Classes to be built:

  • 1D Weight variations (shape, norm or shapenorm)
  • Ndim Weight variations (shape, norm or shapenorm)
  • Tree variations (shape, norm or shapenorm)
  • Ntuple variations (shape, norm or shapenorm)
  • Overall Variations (norm)
@MoAly98 MoAly98 changed the title Add a Systematics class and provide proper treatment of it in Sample class Add classes for various sets of uncertainties Jun 28, 2022
@MoAly98 MoAly98 changed the title Add classes for various sets of uncertainties Add classes for various sets of uncertainties at Histogramming Jun 28, 2022
@MoAly98 MoAly98 changed the title Add classes for various sets of uncertainties at Histogramming Add classes for various sets of systematics at Histogramming Jun 28, 2022
@MoAly98
Copy link
Owner Author

MoAly98 commented Jun 28, 2022

The classes are in-place as sub-classes of a _Systematics class. There are still places in the histogram creation task graph where they are not properly propagated:

Treatment needed for:

  • Retrieving variables needed from input: Line
  • Ndim weight variations for n-dim histograms
  • A post-processing step for norm variations? At the moment histograms are not created form scaling systematics

@MoAly98 MoAly98 self-assigned this Jun 28, 2022
@MoAly98 MoAly98 added bug Something isn't working histogramming related to histogramming code labels Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MoAly98 MoAly98

Labels
bug Something isn't working histogramming related to histogramming code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MoAly98