From eb4047820fe1f942ee00ced549351a79599c296c Mon Sep 17 00:00:00 2001 From: Moaid Hathot Date: Sat, 17 Feb 2024 15:22:21 +0200 Subject: [PATCH] Fixing `IncludeNonePublicMembers` everywhere * Fixing build * Fix IncludeNonePublicMembers everywhere --- README.md | 2 +- docs/readme/nuget.md | 2 +- src/Dumpify.Playground/Program.cs | 27 ++++++++++++------- .../ValueProviders/MemberProvider.cs | 12 ++++----- 4 files changed, 26 insertions(+), 17 deletions(-) diff --git a/README.md b/README.md index 3af4261..68f2b63 100644 --- a/README.md +++ b/README.md @@ -86,7 +86,7 @@ public class AdditionValue } -new AdditionValue(1, 2).Dump(members: new MembersConfig { IncludeFields = true, IncludeNonPublicMembers = true }); +new AdditionValue(1, 2).Dump(members: new MembersConfig { IncludeFields = true, IncludeNonePublicMembers = true }); ``` ![image](https://user-images.githubusercontent.com/8770486/232252840-c5b0ea4c-eae9-4dc2-bd6c-d42ee58505eb.png) diff --git a/docs/readme/nuget.md b/docs/readme/nuget.md index 256ac8a..3693f7d 100644 --- a/docs/readme/nuget.md +++ b/docs/readme/nuget.md @@ -73,7 +73,7 @@ public class AdditionValue } -new AdditionValue(1, 2).Dump(members: new MembersConfig { IncludeFields = true, IncludeNonPublicMembers = true }); +new AdditionValue(1, 2).Dump(members: new MembersConfig { IncludeFields = true, IncludeNonePublicMembers = true }); ``` ![image](https://user-images.githubusercontent.com/8770486/232252840-c5b0ea4c-eae9-4dc2-bd6c-d42ee58505eb.png) diff --git a/src/Dumpify.Playground/Program.cs b/src/Dumpify.Playground/Program.cs index c1094a9..7dc5868 100644 --- a/src/Dumpify.Playground/Program.cs +++ b/src/Dumpify.Playground/Program.cs @@ -1,5 +1,5 @@ using Dumpify; - +using System.Buffers; using System.Collections; using System.ComponentModel; using System.Data; @@ -26,14 +26,23 @@ #pragma warning disable CS8321 #pragma warning disable CS0168 + void TestSpecific() { - ((nuint)5).Dump(); - ((nint)5).Dump(); - 'a'.Dump(); - Enumerable.Range(0, 10).Select(i => (char)(i + 'a')).Dump(); - Enumerable.Range(0, 10).Select(i => (char)(i + 'a')).ToArray().Dump(); - "this is a string".Dump(); + var moaid = new Person { FirstName = "Moaid", LastName = "Hathot", Profession = Profession.Software }; + var moaid2 = new Person { FirstName = "Moaid", LastName = "Hathot", Profession = Profession.Software }; + + Person[] arr = [moaid, moaid]; + arr.Dump(); + + //var value = SearchValues.Create("a"); + //value.Dump(); + // ((nuint)5).Dump(); + // ((nint)5).Dump(); + //'a'.Dump(typeNames: new TypeNamingConfig { }); + // Enumerable.Range(0, 10).Select(i => (char)(i + 'a')).Dump(); + // Enumerable.Range(0, 10).Select(i => (char)(i + 'a')).ToArray().Dump(); + // "this is a string".Dump(); //new TestVirtual().Dump(); // DumpConfig.Default.TypeRenderingConfig.StringQuotationChar = '`'; // @@ -405,8 +414,8 @@ void ShowEverything() new Exception("This is an exception", new ArgumentNullException("blaParam", "This is inner exception")).Dump(); - new AdditionValue(1, 10).Dump(members: new() { IncludeFields = true, IncludeNonPublicMembers = true, IncludeProperties = false }); - new AdditionValue(1, 10).Dump(members: new() { IncludeFields = true, IncludeNonPublicMembers = true }); + new AdditionValue(1, 10).Dump(members: new() { IncludeFields = true, IncludeNonePublicMembers = true, IncludeProperties = false }); + new AdditionValue(1, 10).Dump(members: new() { IncludeFields = true, IncludeNonePublicMembers = true }); //arr.Dump(); //moaid.Dump(); diff --git a/src/Dumpify/Descriptors/ValueProviders/MemberProvider.cs b/src/Dumpify/Descriptors/ValueProviders/MemberProvider.cs index 324bcfc..a402f91 100644 --- a/src/Dumpify/Descriptors/ValueProviders/MemberProvider.cs +++ b/src/Dumpify/Descriptors/ValueProviders/MemberProvider.cs @@ -7,7 +7,7 @@ internal sealed record MemberProvider : IMemberProvider private readonly bool _includeProperties; private readonly bool _includeFields; private readonly bool _includePublicMembers; - private readonly bool _includeNonPublicMembers; + private readonly bool _includeNonePublicMembers; public MemberProvider() : this(true, false, true, false) @@ -15,12 +15,12 @@ public MemberProvider() } - public MemberProvider(bool includeProperties, bool includeFields, bool includePublicMembers, bool includeNonPublicMembers) + public MemberProvider(bool includeProperties, bool includeFields, bool includePublicMembers, bool includeNonePublicMembers) { _includeProperties = includeProperties; _includeFields = includeFields; _includePublicMembers = includePublicMembers; - _includeNonPublicMembers = includeNonPublicMembers; + _includeNonePublicMembers = includeNonePublicMembers; } public IEnumerable GetMembers(Type type) @@ -28,7 +28,7 @@ public IEnumerable GetMembers(Type type) var flags = BindingFlags.Instance; flags |= _includePublicMembers ? BindingFlags.Public : BindingFlags.Default; - flags |= _includeNonPublicMembers ? BindingFlags.NonPublic : BindingFlags.Default; + flags |= _includeNonePublicMembers ? BindingFlags.NonPublic : BindingFlags.Default; var members = Enumerable.Empty(); @@ -60,9 +60,9 @@ public bool Equals(IMemberProvider? provider) return false; } - return _includeProperties == other._includeProperties && _includeFields == other._includeFields && _includePublicMembers == other._includePublicMembers && _includeNonPublicMembers == other._includeNonPublicMembers; + return _includeProperties == other._includeProperties && _includeFields == other._includeFields && _includePublicMembers == other._includePublicMembers && _includeNonePublicMembers == other._includeNonePublicMembers; } public override int GetHashCode() - => (_includeProperties, _includeFields, _includePublicMembers, _includeNonPublicMembers).GetHashCode(); + => (_includeProperties, _includeFields, _includePublicMembers, _includeNonePublicMembers).GetHashCode(); } \ No newline at end of file