Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator does not flag additional fields as invalid #93

Closed
josee-sabourin opened this issue Mar 22, 2023 · 1 comment
Closed

Validator does not flag additional fields as invalid #93

josee-sabourin opened this issue Mar 22, 2023 · 1 comment

Comments

@josee-sabourin
Copy link
Contributor

josee-sabourin commented Mar 22, 2023

Certain feeds with additional non-GBFS fields are being checked as valid.
Example: Citibike includes fields in station_information.json like electric_bike_surcharge_waiver and external_id, but the validation report says no errors.

I believe this might actually be an issue with the schemas and not the validator itself. I am opening the issue on both repositories to be sure.

My initial instinct for a solution would be to add an additionalProperties: false to the schemas, but would like to make sure before opening a PR.

@richfab
Copy link
Contributor

richfab commented Jan 17, 2024

Duplicate of #50

@richfab richfab marked this as a duplicate of #50 Jan 17, 2024
@richfab richfab closed this as completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants