Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happens when more than two edges connect to a single input port? #370

Open
davidt0x opened this issue Jan 11, 2023 · 2 comments
Open

Comments

@davidt0x
Copy link
Contributor

What happens when more that two edges connect to a single input port? This came up in our weekly meeting and we didn't know the answer.

@pgleeson
Copy link
Member

pgleeson commented Apr 26, 2023

Also being worked on here: https://github.com/ModECI/MDF/tree/cyclic_graphs

Need to add a field called reduce, can accept one of 2 keywords , add or multiply, and if inputs of different precisions, will return value of highest precision. Any more complex functions required for combining inputs, should be moved to internally in the node with multiple input ports

@pgleeson pgleeson changed the title What happens when more that two edges connect to a single input port? What happens when more than two edges connect to a single input port? Apr 27, 2023
@pgleeson
Copy link
Member

See: 6b409a0 for initial implementation.

Note: still some open questions about what to do when a single node is run multiple times, e.g. as part of a graph wide condition. Should the current input to the node be added up each time? Probably not, so added a 3rd option overwrite to add and multiply, which is the default for now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants