You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
Description
After unsuccessfully downloading new versions of the mod, you may get an error and the update will fail. However, an empty file of the new mod will be created, which will lead to an error loading mods (see screenshots).
To Reproduce
Install outdated version of some mod
Make ModManager get an error when updating it (I don't know if it's possible to do this on purpose. But in my case it was not possible to update the Fabric API and Amecs)
Close the game
Try to launch MC with empty mod(s) files
See the error
Expected behavior
ModManager should delete empty mod files when they failed to download.
Empty mod files created by MM after failed mod update
Fabric error screen
Error text
Incompatible mod set!
net.fabricmc.loader.impl.FormattedException: net.fabricmc.loader.impl.discovery.ModResolutionException: Mod discovery failed!
at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:192)
at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:142)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:71)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: net.fabricmc.loader.impl.discovery.ModResolutionException: Mod discovery failed!
at net.fabricmc.loader.impl.discovery.ModDiscoverer.lambda$discoverMods$1(ModDiscoverer.java:137)
at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
at net.fabricmc.loader.impl.discovery.ModDiscoverer.discoverMods(ModDiscoverer.java:137)
at net.fabricmc.loader.impl.FabricLoaderImpl.setup(FabricLoaderImpl.java:208)
at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:187)
... 3 more
Caused by: java.lang.RuntimeException: java.lang.RuntimeException: Error analyzing [C:\Users\Александр\AppData\Roaming\.minecraft\home\Fabric 1.18\mods\fabric-api-0.46.4+1.18.jar]: java.util.zip.ZipException: zip file is empty
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480)
at java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:562)
at java.base/java.util.concurrent.ForkJoinTask.reportExecutionException(ForkJoinTask.java:604)
at java.base/java.util.concurrent.ForkJoinTask.get(ForkJoinTask.java:981)
at net.fabricmc.loader.impl.discovery.ModDiscoverer.discoverMods(ModDiscoverer.java:134)
... 5 more
Caused by: java.lang.RuntimeException: Error analyzing [C:\Users\Александр\AppData\Roaming\.minecraft\home\Fabric 1.18\mods\fabric-api-0.46.4+1.18.jar]: java.util.zip.ZipException: zip file is empty
at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.compute(ModDiscoverer.java:237)
at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.compute(ModDiscoverer.java:194)
at java.base/java.util.concurrent.RecursiveTask.exec(RecursiveTask.java:100)
at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)
Caused by: java.util.zip.ZipException: zip file is empty
at java.base/java.util.zip.ZipFile$Source.zerror(ZipFile.java:1598)
at java.base/java.util.zip.ZipFile$Source.findEND(ZipFile.java:1382)
at java.base/java.util.zip.ZipFile$Source.initCEN(ZipFile.java:1477)
at java.base/java.util.zip.ZipFile$Source.(ZipFile.java:1315)
at java.base/java.util.zip.ZipFile$Source.get(ZipFile.java:1277)
at java.base/java.util.zip.ZipFile$CleanableResource.(ZipFile.java:709)
at java.base/java.util.zip.ZipFile.(ZipFile.java:243)
at java.base/java.util.zip.ZipFile.(ZipFile.java:172)
at java.base/java.util.zip.ZipFile.(ZipFile.java:186)
at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.computeJarFile(ModDiscoverer.java:262)
at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.compute(ModDiscoverer.java:232)
... 7 more
The text was updated successfully, but these errors were encountered:
Description
After unsuccessfully downloading new versions of the mod, you may get an error and the update will fail. However, an empty file of the new mod will be created, which will lead to an error loading mods (see screenshots).
To Reproduce
Expected behavior
ModManager should delete empty mod files when they failed to download.
Technical Info
Logs
latest.log
Additional context
Failed updating
latest.log
Screenshots
Updating error

Empty mod files created by MM after failed mod update

Fabric error screen

Error text
Incompatible mod set! net.fabricmc.loader.impl.FormattedException: net.fabricmc.loader.impl.discovery.ModResolutionException: Mod discovery failed! at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:192) at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:142) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:71) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) Caused by: net.fabricmc.loader.impl.discovery.ModResolutionException: Mod discovery failed! at net.fabricmc.loader.impl.discovery.ModDiscoverer.lambda$discoverMods$1(ModDiscoverer.java:137) at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33) at net.fabricmc.loader.impl.discovery.ModDiscoverer.discoverMods(ModDiscoverer.java:137) at net.fabricmc.loader.impl.FabricLoaderImpl.setup(FabricLoaderImpl.java:208) at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:187) ... 3 more Caused by: java.lang.RuntimeException: java.lang.RuntimeException: Error analyzing [C:\Users\Александр\AppData\Roaming\.minecraft\home\Fabric 1.18\mods\fabric-api-0.46.4+1.18.jar]: java.util.zip.ZipException: zip file is empty at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499) at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480) at java.base/java.util.concurrent.ForkJoinTask.getThrowableException(ForkJoinTask.java:562) at java.base/java.util.concurrent.ForkJoinTask.reportExecutionException(ForkJoinTask.java:604) at java.base/java.util.concurrent.ForkJoinTask.get(ForkJoinTask.java:981) at net.fabricmc.loader.impl.discovery.ModDiscoverer.discoverMods(ModDiscoverer.java:134) ... 5 more Caused by: java.lang.RuntimeException: Error analyzing [C:\Users\Александр\AppData\Roaming\.minecraft\home\Fabric 1.18\mods\fabric-api-0.46.4+1.18.jar]: java.util.zip.ZipException: zip file is empty at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.compute(ModDiscoverer.java:237) at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.compute(ModDiscoverer.java:194) at java.base/java.util.concurrent.RecursiveTask.exec(RecursiveTask.java:100) at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) Caused by: java.util.zip.ZipException: zip file is empty at java.base/java.util.zip.ZipFile$Source.zerror(ZipFile.java:1598) at java.base/java.util.zip.ZipFile$Source.findEND(ZipFile.java:1382) at java.base/java.util.zip.ZipFile$Source.initCEN(ZipFile.java:1477) at java.base/java.util.zip.ZipFile$Source.(ZipFile.java:1315) at java.base/java.util.zip.ZipFile$Source.get(ZipFile.java:1277) at java.base/java.util.zip.ZipFile$CleanableResource.(ZipFile.java:709) at java.base/java.util.zip.ZipFile.(ZipFile.java:243) at java.base/java.util.zip.ZipFile.(ZipFile.java:172) at java.base/java.util.zip.ZipFile.(ZipFile.java:186) at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.computeJarFile(ModDiscoverer.java:262) at net.fabricmc.loader.impl.discovery.ModDiscoverer$ModScanTask.compute(ModDiscoverer.java:232) ... 7 moreThe text was updated successfully, but these errors were encountered: